From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Wnwet-0002ED-O2
	for qemu-devel@nongnu.org; Fri, 23 May 2014 17:05:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Wnweo-0001MQ-UI
	for qemu-devel@nongnu.org; Fri, 23 May 2014 17:05:43 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=42864
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Wnweo-0001Lk-Lq
	for qemu-devel@nongnu.org; Fri, 23 May 2014 17:05:38 -0400
Message-ID: <537FB81C.30106@weilnetz.de>
Date: Fri, 23 May 2014 23:05:32 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1400315697-27148-1-git-send-email-sw@weilnetz.de>
	<CAFEAcA8RTfF5+DRff+_kcYNCU=HzX70BQ0O+0vmTaXjucN9zeQ@mail.gmail.com>
In-Reply-To: <CAFEAcA8RTfF5+DRff+_kcYNCU=HzX70BQ0O+0vmTaXjucN9zeQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] w32: Fix regression caused by new g_poll
	implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stanislav Vorobiov <s.vorobiov@samsung.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Sangho Park <sangho1206.park@samsung.com>

Am 23.05.2014 12:36, schrieb Peter Maydell:
> On 17 May 2014 09:34, Stefan Weil <sw@weilnetz.de> wrote:
>> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a
>> performance degradation caused by bad handling of small timeouts
>> in the original implementation of g_poll.
>>
>> Since that commit, hard disk I/O no longer works.
>>
>> Instead of rewriting the g_poll implementation, this patch simply copies
>> the original code (released under LGPL) from latest glib and only modifies
>> it where needed (see comments in the code). URL of the original code:
>> https://git.gnome.org/browse/glib/tree/glib/gpoll.c
> 
> Oops, I didn't notice you'd done that. Our util/oslib-win32.c
> file is marked as having a more liberal license than LGPL.
> So we can't simply copy the LGPL code in without at least
> adjusting the top-of-file comment to indicate which parts
> of the file are LGPL and which are not.
> 
> thanks
> -- PMM
> 


Ah, sorry, I should have read the license comments of oslib-win32.c.
Thanks for that review. If it's sufficient to add some lines to the
license comment, I can send a patch next week. This weekend is reserved
for my family. :-) Or someone else fixes the license statement - that
would be fine, too.

Stefan