All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320
Date: Sat, 24 May 2014 15:29:33 +0200	[thread overview]
Message-ID: <53809EBD.6070706@herbrechtsmeier.net> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D571FF7B539@SC-VEXCH4.marvell.com>

Am 19.05.2014 11:21, schrieb Prafulla Wadaskar:
>> -----Original Message-----
>> From: Bastien ROUCARI?S
>> [mailto:roucaries.bastien at gmail.com]
>> Sent: 18 May 2014 21:51
>> To: u-boot at lists.denx.de
>> Cc: Jamie Lentin; Prafulla Wadaskar; Albert ARIBAUD;
>> Stefan Herbrechtsmeier
>> Subject: [PATCH 4/4] kirkwood: Shorten DNS-325
>> IDENT_STRING to match DNS-320
>>
>> From: Jamie Lentin <jm@lentin.co.uk>
>>
>> You should already know you're using a D-link device.
>>
>> Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
>>
>> Cc: Prafulla Wadaskar <prafulla@marvell.com>
>> Cc: Jamie Lentin <jm@lentin.co.uk>
>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> Cc: Stefan Herbrechtsmeier
>> <stefan@code.herbrechtsmeier.net>
>> ---
>>   include/configs/dnskw.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/dnskw.h
>> b/include/configs/dnskw.h
>> index e55fdc4..7058873 100644
>> --- a/include/configs/dnskw.h
>> +++ b/include/configs/dnskw.h
>> @@ -19,7 +19,7 @@
>>   #ifdef CONFIG_BOARD_IS_DNS325
>>   #define MACH_TYPE_DNS325		3800
>>   #define CONFIG_MACH_TYPE		MACH_TYPE_DNS325
>> -#define CONFIG_IDENT_STRING		"\nD-Link DNS-325"
>> +#define CONFIG_IDENT_STRING		"\nDNS-325"
> First of all thanks for preferring short names.
>
> Since the file is renamed to dnskw, and there are two or more boards supported like 320 and 325,
>
> Does above string makes sense? Or you should better name to some common name? like "DNSKW"?
Because the u-boot.kwb is different for the boards I would prefer 
different names.

  reply	other threads:[~2014-05-24 13:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-18 16:21 [U-Boot] [V2][PATCH 0/4] Support d-link dns320 (arch kirkwood) Bastien ROUCARIÈS
2014-05-18 16:21 ` [U-Boot] [PATCH 1/4] kirkwood: Rename dns325 to dnskw Bastien ROUCARIÈS
2014-05-18 16:21 ` [U-Boot] [PATCH 2/4] kirkwood: Add support for the D-Link DNS-320 Bastien ROUCARIÈS
2014-05-19 17:15   ` Stefan Herbrechtsmeier
2014-05-18 16:21 ` [U-Boot] [PATCH 3/4] kirkwood: Set unused SD pins back to GPIO for DNS-320 & DNS-325 Bastien ROUCARIÈS
2014-05-18 16:21 ` [U-Boot] [PATCH 4/4] kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320 Bastien ROUCARIÈS
2014-05-19  9:21   ` Prafulla Wadaskar
2014-05-24 13:29     ` Stefan Herbrechtsmeier [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-08 16:30 [U-Boot] [PATCH 1/4] kirkwood: Rename dns325 to dnskw Bastien ROUCARIÈS
2014-06-08 16:30 ` [U-Boot] [PATCH 4/4] kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320 Bastien ROUCARIÈS
2014-07-04 17:01 ` [U-Boot] [PATCH v4: DNS320 support 0/4] Add a new kirkwook board Bastien ROUCARIÈS
2014-07-04 17:01   ` [U-Boot] [PATCH 4/4] kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320 Bastien ROUCARIÈS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53809EBD.6070706@herbrechtsmeier.net \
    --to=stefan@herbrechtsmeier.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.