From: Balakumaran Kannan <kumaran.4353@gmail.com>
To: steve.glendinning@shawell.net, davem@davemloft.net,
netdev@vger.kernel.org
Subject: [PATCH 1/1] driver: net: smsc911x: set NOCARRIER flag in driver initialization
Date: Sun, 25 May 2014 00:24:46 +0530 [thread overview]
Message-ID: <5380EAF6.1090402@gmail.com> (raw)
As smsc driver supports carrier detection, it should unset NOCARRIER
flag only after carrier state determination. By default that flag
is off so driver should set it before starting auto-negotiation
Signed-off-by: Balakumaran Kannan <Balakumaran.Kannan@ap.sony.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index a0fc151..69016a5 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2525,6 +2525,8 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
netdev_info(dev, "MAC Address: %pM\n", dev->dev_addr);
+ netif_carrier_off(dev);
+
return 0;
out_unregister_netdev_5:
--
1.8.3.2
next reply other threads:[~2014-05-24 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 18:54 Balakumaran Kannan [this message]
2014-05-29 22:28 ` [PATCH 1/1] driver: net: smsc911x: set NOCARRIER flag in driver initialization David Miller
2014-05-30 13:05 ` Balakumaran Kannan
2014-05-30 20:42 ` David Miller
2014-06-03 14:15 ` Balakumaran Kannan
2014-06-03 16:29 ` Florian Fainelli
2014-06-03 22:24 ` David Miller
2014-06-04 5:05 ` Balakumaran Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5380EAF6.1090402@gmail.com \
--to=kumaran.4353@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.