From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/7] configure: Enable out-of-tree iotests
Date: Sat, 24 May 2014 21:27:32 +0200 [thread overview]
Message-ID: <5380F2A4.7020309@redhat.com> (raw)
In-Reply-To: <20140523034742.GC1668@T430.nay.redhat.com>
On 23.05.2014 05:47, Fam Zheng wrote:
> On Thu, 05/22 23:30, Max Reitz wrote:
>> In order to allow out-of-tree iotests, create a symlink for the check
>> script in the build tree.
>>
>> While doing so, also write configured options relevant to the iotests to
>> common.env in the build tree; currently, this is the command to invoke
>> Python 2.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> configure | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 605a0ec..f9d7a4d 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5206,6 +5206,18 @@ if test "$docs" = "yes" ; then
>> mkdir -p QMP
>> fi
>>
>> +# set up qemu-iotests in this build directory
>> +iotests_common_env="tests/qemu-iotests/common.env"
>> +iotests_check="tests/qemu-iotests/check"
>> +
>> +echo "# Automatically generated by configure - do not modify" > "$iotests_common_env"
>> +echo >> "$iotests_common_env"
>> +echo "export PYTHON='$python'" >> "$iotests_common_env"
>> +
>> +if [ ! -e "$iotests_check" ]; then
>> + ln -s "$source_path/$iotests_check" "$iotests_check"
>> +fi
>> +
> Please use symlink().
I'll do.
Max
next prev parent reply other threads:[~2014-05-24 19:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 21:30 [Qemu-devel] [PATCH v3 0/7] iotests: Allow out-of-tree run Max Reitz
2014-05-22 21:30 ` [Qemu-devel] [PATCH v3 1/7] " Max Reitz
2014-05-23 3:44 ` Fam Zheng
2014-05-22 21:30 ` [Qemu-devel] [PATCH v3 2/7] configure: Enable out-of-tree iotests Max Reitz
2014-05-23 3:47 ` Fam Zheng
2014-05-24 19:27 ` Max Reitz [this message]
2014-05-22 21:30 ` [Qemu-devel] [PATCH v3 3/7] iotests: Add default common.env Max Reitz
2014-05-23 6:10 ` Fam Zheng
2014-05-23 12:27 ` Eric Blake
2014-05-23 13:33 ` Markus Armbruster
2014-05-24 19:40 ` Max Reitz
2014-05-22 21:30 ` [Qemu-devel] [PATCH v3 4/7] iotests: Source common.env Max Reitz
2014-05-23 4:01 ` Fam Zheng
2014-05-24 20:18 ` Max Reitz
2014-05-22 21:30 ` [Qemu-devel] [PATCH v3 5/7] iotests: Use $PYTHON for Python scripts Max Reitz
2014-05-23 3:58 ` Fam Zheng
2014-05-24 19:35 ` Max Reitz
2014-05-22 21:30 ` [Qemu-devel] [PATCH v3 6/7] iotests: Drop Python version from 065's Shebang Max Reitz
2014-05-23 4:02 ` Fam Zheng
2014-05-22 21:30 ` [Qemu-devel] [PATCH v3 7/7] iotests: Fix 083 for out-of-tree builds Max Reitz
2014-05-22 21:35 ` [Qemu-devel] [PATCH v3 0/7] iotests: Allow out-of-tree run Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5380F2A4.7020309@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.