From: Lars-Peter Clausen <lars@metafoo.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Kp Jeeja <jeeja.kp@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
lgirdwood@gmail.com
Subject: Re: [PATCH 1/2] ASoC: add api for dapm kcontrol configiuration
Date: Mon, 26 May 2014 15:26:39 +0200 [thread overview]
Message-ID: <5383410F.9020404@metafoo.de> (raw)
In-Reply-To: <1401106136-3745-1-git-send-email-vinod.koul@intel.com>
On 05/26/2014 02:08 PM, Vinod Koul wrote:
> From: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
>
> For DSPs we need to set and get the value for snd_kcontrol. This is currently
> done by dapm_kcontrol_set/get_value, so create a wrapper
> snd_soc_dapm_kcontrol_get/set_value APIs to let drivers use this
Can you go a bit more into detail how you intend to use this?
> [...]
> +unsigned int snd_soc_dapm_kcontrol_get_value(
> + const struct snd_kcontrol *kcontrol)
> +{
> + dapm_kcontrol_get_value(kcontrol);
The compiler should have complained about this.
> +}
> +EXPORT_SYMBOL_GPL(snd_soc_dapm_kcontrol_get_value);
I'm also not sure how much sense it makes to have a single line wrapper
function for exporting things? Why not just rename the original function and
then export it?
next prev parent reply other threads:[~2014-05-26 13:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 12:08 [PATCH 1/2] ASoC: add api for dapm kcontrol configiuration Vinod Koul
2014-05-26 12:08 ` [PATCH 2/2] ASoC: dapm: Add a helper to get the platform for DAPM kcontrol Vinod Koul
2014-05-26 12:44 ` Jarkko Nikula
2014-05-26 12:51 ` Vinod Koul
2014-05-26 14:29 ` Mark Brown
2014-05-26 13:29 ` Lars-Peter Clausen
2014-05-26 16:23 ` Vinod Koul
2014-05-26 16:52 ` Lars-Peter Clausen
2014-05-26 16:47 ` Vinod Koul
2014-05-26 18:07 ` Lars-Peter Clausen
2014-05-26 18:54 ` Mark Brown
2014-05-26 13:26 ` Lars-Peter Clausen [this message]
2014-05-26 15:05 ` [PATCH 1/2] ASoC: add api for dapm kcontrol configiuration Mark Brown
2014-05-26 16:18 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5383410F.9020404@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.