From: Paolo Bonzini <pbonzini@redhat.com>
To: Jeff Smith <jsmith.lkml@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Kenny Simpson <theonetruekenny@gmail.com>,
Michal Hocko <mhocko@suse.cz>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Dave Jones <davej@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: remap_file_pages() use
Date: Mon, 26 May 2014 15:35:12 +0200 [thread overview]
Message-ID: <53834310.8060808@redhat.com> (raw)
In-Reply-To: <CAAih0Nght-5k6mp-_jc+GipxPfxPYdCEabH_8M2QMkM_B5FPWw@mail.gmail.com>
Il 26/05/2014 15:24, Jeff Smith ha scritto:
> Your addr2 mmap() call is a bit incorrect semantically and
> syntactically (you skipped the length arg). The addr2 request will
> fail because mmap() does not implicitly munmap() occupied virtual
> address space.
With MAP_FIXED it does. It is in the man page.
Paolo
> Even if you did that, the following still has a race
> condition between the addr2 request and another thread grabbing the
> same virtual space, which nothing short of a lock on all threads'
> mmap()-ing logic can protect:
next prev parent reply other threads:[~2014-05-26 13:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 4:03 remap_file_pages() use Kenny Simpson
2014-05-19 13:01 ` Michal Hocko
2014-05-19 14:35 ` Kirill A. Shutemov
2014-05-19 14:38 ` Christoph Hellwig
2014-05-19 15:02 ` Kirill A. Shutemov
2014-05-19 15:11 ` Christoph Hellwig
2014-05-19 15:17 ` Kirill A. Shutemov
2014-05-19 15:42 ` Armin Rigo
2014-05-19 15:53 ` Kirill A. Shutemov
2014-05-19 16:42 ` Armin Rigo
2014-05-19 17:50 ` Dave Hansen
2014-05-19 22:05 ` Armin Rigo
2014-05-19 16:56 ` Christoph Hellwig
2014-05-19 19:14 ` Richard Weinberger
2014-05-26 0:19 ` Jeff Smith
2014-05-26 9:42 ` Kirill A. Shutemov
2014-05-26 13:24 ` Jeff Smith
2014-05-26 13:35 ` Paolo Bonzini [this message]
2014-05-26 13:38 ` Jeff Smith
2014-05-26 13:47 ` Kirill A. Shutemov
2014-05-26 13:52 ` Jeff Smith
2014-05-26 14:16 ` Kirill A. Shutemov
2014-05-26 13:37 ` Kirill A. Shutemov
2014-05-19 17:34 ` Kenny Simpson
2014-05-19 21:24 ` Kirill A. Shutemov
2014-05-21 1:53 ` Kenny Simpson
2014-05-21 3:56 ` Kenny Simpson
2014-05-21 4:32 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53834310.8060808@redhat.com \
--to=pbonzini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=hch@infradead.org \
--cc=jsmith.lkml@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=peterz@infradead.org \
--cc=theonetruekenny@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.