Re: [PATCH 0/7] drm & drivers: kill drm_get_connector_name() and drm_get_encoder_name()

["Christian König" <deathsimple@vodafone.de>]

Am 26.05.2014 15:52, schrieb Daniel Vetter:
> On Mon, May 26, 2014 at 3:52 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Mon, May 26, 2014 at 04:35:39PM +0300, Jani Nikula wrote:
>>> As requested by David [1],[2].
>>>
>>> These are on top of drm-intel-nightly which carries the required core
>>> patches adding ->name field to drm_connector and drm_encoder. The i915
>>> patches could go in right away, the last patch need to wait for radeon
>>> and nouveau patches to get merged, obviously.
>> For easier merging I'd might be best to throw them all into the
>> topic/core-stuff branch I have, since that's where your previous patch
>> also landed. I.e. I can't merge the i915 patches right away.
>>
>> Ben, Alex/Christian, Dave: Ack for this plan (and the patches)?

In general sounds like a good idea to me, no need for the wrappers when 
they just retrieve a structure field.

Christian.

> Blergh, forgotten to put Dave onto the recipient list.
> -Daniel
>
>> -Daniel
>>
>>> BR,
>>> Jani.
>>>
>>>
>>> [1] http://mid.gmane.org/CANq1E4SBLr32kimS=Cxe5=sjZJJ9AVt7yxp3LfiOuMKSNC-CCA@mail.gmail.com
>>> [2] http://mid.gmane.org/CANq1E4QifeSoQ4pMfi1K+fgeCWYkvuBGDpjwand_Grabn+9Jow@mail.gmail.com
>>>
>>> Jani Nikula (7):
>>>    drm/i915: replace drm_get_connector_name() with direct name field use
>>>    drm/nouveau: replace drm_get_connector_name() with direct name field
>>>      use
>>>    drm/radeon: replace drm_get_connector_name() with direct name field
>>>      use
>>>    drm: replace drm_get_connector_name() with direct name field use
>>>    drm/i915: replace drm_get_encoder_name() with direct name field use
>>>    drm: replace drm_get_encoder_name() with direct name field use
>>>    drm: drop drm_get_connector_name() and drm_get_encoder_name()
>>>
>>>   drivers/gpu/drm/drm_crtc.c                  | 26 +++----------------------
>>>   drivers/gpu/drm/drm_crtc_helper.c           |  8 ++++----
>>>   drivers/gpu/drm/drm_edid.c                  |  6 +++---
>>>   drivers/gpu/drm/drm_edid_load.c             |  2 +-
>>>   drivers/gpu/drm/drm_fb_helper.c             |  6 +++---
>>>   drivers/gpu/drm/drm_probe_helper.c          | 10 +++++-----
>>>   drivers/gpu/drm/drm_sysfs.c                 |  6 +++---
>>>   drivers/gpu/drm/i915/i915_debugfs.c         |  6 +++---
>>>   drivers/gpu/drm/i915/i915_irq.c             |  8 ++++----
>>>   drivers/gpu/drm/i915/intel_crt.c            |  2 +-
>>>   drivers/gpu/drm/i915/intel_display.c        | 30 ++++++++++++++---------------
>>>   drivers/gpu/drm/i915/intel_dp.c             |  4 ++--
>>>   drivers/gpu/drm/i915/intel_dvo.c            |  2 +-
>>>   drivers/gpu/drm/i915/intel_fbdev.c          | 14 +++++++-------
>>>   drivers/gpu/drm/i915/intel_hdmi.c           |  2 +-
>>>   drivers/gpu/drm/i915/intel_lvds.c           |  2 +-
>>>   drivers/gpu/drm/i915/intel_panel.c          |  2 +-
>>>   drivers/gpu/drm/i915/intel_sdvo.c           |  8 ++++----
>>>   drivers/gpu/drm/i915/intel_tv.c             |  2 +-
>>>   drivers/gpu/drm/nouveau/dispnv04/dac.c      |  2 +-
>>>   drivers/gpu/drm/nouveau/dispnv04/dfp.c      |  2 +-
>>>   drivers/gpu/drm/nouveau/dispnv04/disp.c     |  2 +-
>>>   drivers/gpu/drm/nouveau/dispnv04/tvnv04.c   |  3 ++-
>>>   drivers/gpu/drm/nouveau/dispnv04/tvnv17.c   |  3 +--
>>>   drivers/gpu/drm/nouveau/nouveau_connector.c |  8 ++++----
>>>   drivers/gpu/drm/nouveau/nv50_display.c      |  2 +-
>>>   drivers/gpu/drm/radeon/radeon_connectors.c  | 19 +++++++++++-------
>>>   drivers/gpu/drm/radeon/radeon_display.c     |  2 +-
>>>   include/drm/drm_crtc.h                      |  2 --
>>>   29 files changed, 87 insertions(+), 104 deletions(-)
>>>
>>> --
>>> 1.9.1
>>>
>>> _______________________________________________
>>> dri-devel mailing list
>>> dri-devel@lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>
>