From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ananyev,
Konstantin"
<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"dev-VfR2kkLFssw@public.gmane.org"
<dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] atomic: clarify use of memory barriers
Date: Mon, 26 May 2014 16:20:05 +0200 [thread overview]
Message-ID: <53834D95.30309@6wind.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB0A95-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hi Konstantin,
On 05/26/2014 03:57 PM, Ananyev, Konstantin wrote:
> In most cases just a compiler barrier is enough, but there are few exceptions.
> Always using fence instructions - means introduce unnecessary slowdown for cases, when order is guaranteed.
> No using fences in cases, when they are needed - means introduce race window and possible data corruption.
> That's why right now people can use either rte_compiler_barrier() or mb/rmb/wmb - whatever is appropriate for particular case.
OK, so let's drop this patch for now.
Thank you for reviewing and commenting.
Regards,
Olivier
prev parent reply other threads:[~2014-05-26 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 9:36 [PATCH] atomic: clarify use of memory barriers Olivier Matz
[not found] ` <1400578588-21137-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-05-20 10:05 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772580EFA776F-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-20 12:12 ` Olivier MATZ
[not found] ` <537B46B4.4000202-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-05-20 16:35 ` Ananyev, Konstantin
2014-05-23 14:10 ` Olivier MATZ
[not found] ` <537F56C3.3060503-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-05-26 13:57 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772580EFB0A95-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-26 14:20 ` Olivier MATZ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53834D95.30309@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.