Re: [PATCH 09/11] omap3isp: ccdc: Add basic support for interlaced video

[Sakari Ailus <sakari.ailus@iki.fi>]

Hi Laurent,

Laurent Pinchart wrote:
> When the CCDC input is interlaced enable the alternate field order on
> the CCDC output video node. The field signal polarity is specified
> through platform data.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   drivers/media/platform/omap3isp/ispccdc.c  | 21 ++++++++++++++++++++-
>   drivers/media/platform/omap3isp/ispvideo.c |  6 ++++++
>   drivers/media/platform/omap3isp/ispvideo.h |  2 ++
>   include/media/omap3isp.h                   |  3 +++
>   4 files changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
> index 76d4fd7..49d7256 100644
> --- a/drivers/media/platform/omap3isp/ispccdc.c
> +++ b/drivers/media/platform/omap3isp/ispccdc.c
...
> @@ -1830,6 +1845,11 @@ ccdc_try_format(struct isp_ccdc_device *ccdc, struct v4l2_subdev_fh *fh,
>   		/* Clamp the input size. */
>   		fmt->width = clamp_t(u32, width, 32, 4096);
>   		fmt->height = clamp_t(u32, height, 32, 4096);
> +
> +		/* Default to progressive field order. */
> +		if (fmt->field == V4L2_FIELD_ANY)
> +			fmt->field = V4L2_FIELD_NONE;

I think this change would better fit in "omap3isp: Default to 
progressive field order when setting the format". Then you could omit " 
when setting the format". :-)

-- 
Kind regards,

Sakari Ailus
sakari.ailus@iki.fi