* [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission
@ 2014-05-27 0:56 Marek Olšák
2014-05-27 9:08 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Marek Olšák @ 2014-05-27 0:56 UTC (permalink / raw)
To: dri-devel
From: Marek Olšák <marek.olsak@amd.com>
It hangs the hardware.
Signed-off-by: Marek Olšák <marek.olsak@amd.com>
---
drivers/gpu/drm/radeon/radeon_cs.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 2b6e0eb..2b78191 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -152,6 +152,12 @@ static int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
uint32_t domain = r->write_domain ?
r->write_domain : r->read_domains;
+ if (domain & RADEON_GEM_DOMAIN_CPU) {
+ DRM_ERROR("RADEON_GEM_DOMAIN_CPU is not valid "
+ "for command submission\n");
+ return -EINVAL;
+ }
+
p->relocs[i].domain = domain;
if (domain == RADEON_GEM_DOMAIN_VRAM)
domain |= RADEON_GEM_DOMAIN_GTT;
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission
2014-05-27 0:56 [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission Marek Olšák
@ 2014-05-27 9:08 ` Christian König
2014-05-27 12:32 ` Marek Olšák
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2014-05-27 9:08 UTC (permalink / raw)
To: Marek Olšák, dri-devel
Am 27.05.2014 02:56, schrieb Marek Olšák:
> From: Marek Olšák <marek.olsak@amd.com>
>
> It hangs the hardware.
>
> Signed-off-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Maybe CC stable as well? Anyway going to add it to my 3.15 queue.
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_cs.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
> index 2b6e0eb..2b78191 100644
> --- a/drivers/gpu/drm/radeon/radeon_cs.c
> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> @@ -152,6 +152,12 @@ static int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
> uint32_t domain = r->write_domain ?
> r->write_domain : r->read_domains;
>
> + if (domain & RADEON_GEM_DOMAIN_CPU) {
> + DRM_ERROR("RADEON_GEM_DOMAIN_CPU is not valid "
> + "for command submission\n");
> + return -EINVAL;
> + }
> +
> p->relocs[i].domain = domain;
> if (domain == RADEON_GEM_DOMAIN_VRAM)
> domain |= RADEON_GEM_DOMAIN_GTT;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission
2014-05-27 9:08 ` Christian König
@ 2014-05-27 12:32 ` Marek Olšák
0 siblings, 0 replies; 3+ messages in thread
From: Marek Olšák @ 2014-05-27 12:32 UTC (permalink / raw)
To: Christian König; +Cc: dri-devel
Yeah, feel free to add the Cc: stable tag.
Marek
On Tue, May 27, 2014 at 11:08 AM, Christian König
<deathsimple@vodafone.de> wrote:
> Am 27.05.2014 02:56, schrieb Marek Olšák:
>
>> From: Marek Olšák <marek.olsak@amd.com>
>>
>> It hangs the hardware.
>>
>> Signed-off-by: Marek Olšák <marek.olsak@amd.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Maybe CC stable as well? Anyway going to add it to my 3.15 queue.
>
> Christian.
>
>
>> ---
>> drivers/gpu/drm/radeon/radeon_cs.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c
>> b/drivers/gpu/drm/radeon/radeon_cs.c
>> index 2b6e0eb..2b78191 100644
>> --- a/drivers/gpu/drm/radeon/radeon_cs.c
>> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
>> @@ -152,6 +152,12 @@ static int radeon_cs_parser_relocs(struct
>> radeon_cs_parser *p)
>> uint32_t domain = r->write_domain ?
>> r->write_domain : r->read_domains;
>> + if (domain & RADEON_GEM_DOMAIN_CPU) {
>> + DRM_ERROR("RADEON_GEM_DOMAIN_CPU is not
>> valid "
>> + "for command submission\n");
>> + return -EINVAL;
>> + }
>> +
>> p->relocs[i].domain = domain;
>> if (domain == RADEON_GEM_DOMAIN_VRAM)
>> domain |= RADEON_GEM_DOMAIN_GTT;
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-27 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-27 0:56 [PATCH] drm/radeon: don't allow RADEON_GEM_DOMAIN_CPU for command submission Marek Olšák
2014-05-27 9:08 ` Christian König
2014-05-27 12:32 ` Marek Olšák
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.