Re: [PATCH kvm-unit-tests 00/18] lib/x86 TLC, extending tests for both 32- and 64-bits, and SMAP tests

[Paolo Bonzini <pbonzini@redhat.com>]

Il 28/04/2014 17:22, Paolo Bonzini ha scritto:
> This series is structured as follows:
>
> - patches 1 to 8 cleanup lib/x86/, remove gratuitous differences
>   between 32-bit and 64-bit, and unify code that is duplicated in
>   various ways
>
> - patches 9 to 12 port some eventinj tests so that they run as
>   64-bit hosts too
>
> - patches 13 to 15 are cleanups
>
> - patches 16 to 18 add a testcase for SMAP (tested with QEMU by me
>   and, by the patch submitter, with KVM)

I pushed most of this series, except patches 16 and 18.

I didn't add the SMAP testcase because Avi suggested on IRC adding the 
SMAP testcases to access.flat.  It's a good idea, but there are a lot of 
TCG bugs in this area that access.flat detects, and they block my SMAP 
testing.  If I can fix these bugs, I'll add the testcases to 
access.flat.  Otherwise, I'll commit patches 16 and 18 too.

Paolo

> Paolo Bonzini (18):
>   libcflat: move stringification trick to a common place
>   x86: move size #defines to processor.h
>   x86: desc: change set_gdt_entry argument to selector
>   x86: desc: move idt_entry_t and gdt_entry_t to header
>   x86: desc: reuse cstart.S GDT and TSS
>   x86: taskswitch: use desc library
>   x86: unify GDT format between 32-bit and 64-bit
>   x86: move CR0 and CR4 constants to processor.h
>   x86: desc: support ISTs for alternate stacks in 64-bit mode
>   x86: eventinj: fix inline assembly and make it more robust to new compilers
>   x86: eventinj: enable NP test in 64-bit mode
>   x86: eventinj: port consecutive exception tests to x86-64
>   x86: xsave: use cpuid functions from processor.h
>   x86: svm: rename get_pte function
>   x86: vm: remove dead code
>   x86: vm: export get_pte and return a pointer to it
>   x86: vm: mark intermediate PTEs as user-accessible
>   x86: smap: new testcase
>
>  config-x86-common.mak |   4 +-
>  lib/libcflat.h        |   3 +
>  lib/x86/desc.c        | 166 +++++++++++++++++---------------------------------
>  lib/x86/desc.h        |  80 ++++++++++++++++++++----
>  lib/x86/isr.c         |   6 --
>  lib/x86/processor.h   |  38 +++++++++++-
>  lib/x86/vm.c          |  60 +++++++-----------
>  lib/x86/vm.h          |  42 +++----------
>  x86/asyncpf.c         |   1 -
>  x86/cstart.S          |  16 +++++
>  x86/cstart64.S        |  17 ++++--
>  x86/eventinj.c        |  87 ++++++++++++++++----------
>  x86/pcid.c            |   7 ---
>  x86/smap.c            | 156 +++++++++++++++++++++++++++++++++++++++++++++++
>  x86/svm.c             |  18 +++---
>  x86/taskswitch.c      | 134 +++-------------------------------------
>  x86/taskswitch2.c     |  19 +++---
>  x86/vmexit.c          |   6 --
>  x86/vmx.c             |  32 +++++-----
>  x86/xsave.c           |  58 ++----------------
>  20 files changed, 485 insertions(+), 465 deletions(-)
>  create mode 100644 x86/smap.c
>