From: "P. van Gaans" <w3ird_n3rd@gmx.net>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Subject: Re: [PATCH] em28xx: add MSI Digivox Trio support
Date: Tue, 27 May 2014 16:30:32 +0200 [thread overview]
Message-ID: <5384A188.7040906@gmx.net> (raw)
In-Reply-To: <53843AD3.7060601@xs4all.nl>
On 05/27/2014 09:12 AM, Hans Verkuil wrote:
> On 05/27/2014 02:04 AM, P. van Gaans wrote:
>> http://linuxtv.org/wiki/index.php/MSI_DigiVox_Trio
>>
>> If you're having a deja-vu, yeah, it's still me. I'm still using this
>> device using my butt-ugly patch by adding:
>>
>> { USB_DEVICE(0xeb1a, 0x2885), /* MSI Digivox Trio */
>> .driver_info = EM2884_BOARD_TERRATEC_H5 },
>>
>> to linux/drivers/media/usb/em28xx/em28xx-cards.c.
>>
>> It's starting to bug me more and more that I can never update my kernel
>> (well not without hassle anyway). I've written this to the mailinglist
>> before, but with no response.
>>
>> I just don't have the skill to write this in the neat way it needs to be
>> to be able to go upstream. Should I try to hire someone to do that? If
>> so, any suggestions? Just put an ad up on craigslist or something? Does
>> such a patch have a chance of going upstream? (as that's the whole point
>> - I want to update my kernel again)
>>
>> It should be really straightforward given that no reverse engineering or
>> anything is needed. It's just what it states above - pretend the Digivox
>> is an H5 and it's done.
>>
>> Anyone who can tune in on this, please share your thoughts.
>
> I've made it into a proper patch, see below.
>
> Can you reply with your 'Signed-off-by' line?
>
> i.e.: Signed-off-by: John Doe <john.doe@foo.com>
>
> Since you're the author of the patch (I just formatted it), I need that to
> get it upstream.
>
> Regards,
>
> Hans
>
> diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
> index 15ad470..9da812b 100644
> --- a/drivers/media/usb/em28xx/em28xx-cards.c
> +++ b/drivers/media/usb/em28xx/em28xx-cards.c
> @@ -2280,6 +2280,8 @@ struct usb_device_id em28xx_id_table[] = {
> .driver_info = EM2820_BOARD_UNKNOWN },
> { USB_DEVICE(0xeb1a, 0x2875),
> .driver_info = EM2820_BOARD_UNKNOWN },
> + { USB_DEVICE(0xeb1a, 0x2885), /* MSI Digivox Trio */
> + .driver_info = EM2884_BOARD_TERRATEC_H5 },
> { USB_DEVICE(0xeb1a, 0xe300),
> .driver_info = EM2861_BOARD_KWORLD_PVRTV_300U },
> { USB_DEVICE(0xeb1a, 0xe303),
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Thank you!
Signed-off-by: P. van Gaans <w3ird_n3rd@gmx.net>
prev parent reply other threads:[~2014-05-27 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 0:04 MSI Digivox Trio, should I try to hire someone to patch for this device? P. van Gaans
2014-05-27 7:12 ` [PATCH] em28xx: add MSI Digivox Trio support Hans Verkuil
2014-05-27 14:30 ` P. van Gaans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5384A188.7040906@gmx.net \
--to=w3ird_n3rd@gmx.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.