From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] block: flush queued bios when the process blocks Date: Tue, 27 May 2014 11:42:26 -0600 Message-ID: <5384CE82.90601@kernel.dk> References: <5384AA79.4010206@kernel.dk> <5384B26D.1000703@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Mikulas Patocka Cc: Kent Overstreet , linux-kernel@vger.kernel.org, dm-devel@redhat.com, "Alasdair G. Kergon" , Mike Snitzer List-Id: dm-devel.ids On 2014-05-27 10:26, Mikulas Patocka wrote: > On Tue, 27 May 2014, Jens Axboe wrote: > >> On 2014-05-27 09:23, Mikulas Patocka wrote: >> >>> The patch adds bio list flushing to the scheduler just besides plug >>> flushsing. >> >> ... which is exactly why I'm commenting. It'd be great to avoid yet one more >> scheduler hook for this sort of thing. >> >> -- >> Jens Axboe > > One could create something like schedule notifier chain, but I'm not sure > if it is worth the complexity because of just two users. If more users > come in the future, it could be generalized. Except such a thing already exists, there are unplug callback chains. All I'm asking is that you look into how feasible it would be to use something like that, instead of reinventing the wheel. -- Jens Axboe