From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled Date: Tue, 27 May 2014 17:03:59 -0400 Message-ID: <5384FDBF.2050604@ti.com> References: <20140519172338.GJ4849@atomide.com> <537A408F.7070301@ti.com> <20140519175157.GK4849@atomide.com> <537A4827.30604@linaro.org> <20140519193622.GA11945@atomide.com> <537A5F5B.6050403@linaro.org> <537A7522.30007@math.uni-bielefeld.de> <20140523144425.GB2321@atomide.com> <20140523183228.GH2321@atomide.com> <20140527203452.GA32336@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:55569 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbaE0VE3 (ORCPT ); Tue, 27 May 2014 17:04:29 -0400 In-Reply-To: <20140527203452.GA32336@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren , Daniel Lezcano Cc: Tobias Jakobi , Alex Shi , Kevin Hilman , Linux ARM Kernel ML , linux-omap@vger.kernel.org, Roger Quadros On Tuesday 27 May 2014 04:34 PM, Tony Lindgren wrote: > * Daniel Lezcano [140523 13:53]: >> On 23 May 2014 20:32, Tony Lindgren wrote: >> >>> * Tony Lindgren [140523 07:45]: >>>> * Tobias Jakobi [140519 14:19]: >>>>> >>>>> But even if I don't connect via WiFi at all, just boot and let me >>> system >>>>> run with serial console connected, after some time I get a kernel >>> 'WARNING': >>>>> http://www.math.uni-bielefeld.de/~tjakobi/archive/dmesg.1.log >>>> >>>> BTW, care to update the bugzilla page with the second warning >>>> in this log? >>>> >>>> That's the WARNING: CPU: 1 PID: 0 at kernel/timer.c:1147 that's >>>> at 238 seconds. >>> >>> Also, with Santosh's fix applied, can you also try disabling one >>> or more of the idle states for cpuidle and see if that helps? >>> >>> Something like this patch below. If that helps with the WARNING >>> above you're getting it narrows down the problem down quite a bit. >>> >>> Regards, >>> >>> Tony >>> >>> --- a/arch/arm/mach-omap2/cpuidle44xx.c >>> +++ b/arch/arm/mach-omap2/cpuidle44xx.c >>> @@ -44,11 +44,13 @@ static struct idle_statedata omap4_idle_data[] = { >>> .mpu_state = PWRDM_POWER_RET, >>> .mpu_logic_state = PWRDM_POWER_RET, >>> }, >>> +#if 0 >>> { >>> .cpu_state = PWRDM_POWER_OFF, >>> .mpu_state = PWRDM_POWER_RET, >>> .mpu_logic_state = PWRDM_POWER_OFF, >>> }, >>> +#endif >>> >> >> Hmm, I am afraid that will lead to a fault. Safer to set the state_count = >> 2 instead. > > Hmm don't we have state_count = ARRAY_SIZE(omap4_idle_data) or am I > missing something? > I don't think you are missing anything. The change should work. From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Tue, 27 May 2014 17:03:59 -0400 Subject: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled In-Reply-To: <20140527203452.GA32336@atomide.com> References: <20140519172338.GJ4849@atomide.com> <537A408F.7070301@ti.com> <20140519175157.GK4849@atomide.com> <537A4827.30604@linaro.org> <20140519193622.GA11945@atomide.com> <537A5F5B.6050403@linaro.org> <537A7522.30007@math.uni-bielefeld.de> <20140523144425.GB2321@atomide.com> <20140523183228.GH2321@atomide.com> <20140527203452.GA32336@atomide.com> Message-ID: <5384FDBF.2050604@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 27 May 2014 04:34 PM, Tony Lindgren wrote: > * Daniel Lezcano [140523 13:53]: >> On 23 May 2014 20:32, Tony Lindgren wrote: >> >>> * Tony Lindgren [140523 07:45]: >>>> * Tobias Jakobi [140519 14:19]: >>>>> >>>>> But even if I don't connect via WiFi at all, just boot and let me >>> system >>>>> run with serial console connected, after some time I get a kernel >>> 'WARNING': >>>>> http://www.math.uni-bielefeld.de/~tjakobi/archive/dmesg.1.log >>>> >>>> BTW, care to update the bugzilla page with the second warning >>>> in this log? >>>> >>>> That's the WARNING: CPU: 1 PID: 0 at kernel/timer.c:1147 that's >>>> at 238 seconds. >>> >>> Also, with Santosh's fix applied, can you also try disabling one >>> or more of the idle states for cpuidle and see if that helps? >>> >>> Something like this patch below. If that helps with the WARNING >>> above you're getting it narrows down the problem down quite a bit. >>> >>> Regards, >>> >>> Tony >>> >>> --- a/arch/arm/mach-omap2/cpuidle44xx.c >>> +++ b/arch/arm/mach-omap2/cpuidle44xx.c >>> @@ -44,11 +44,13 @@ static struct idle_statedata omap4_idle_data[] = { >>> .mpu_state = PWRDM_POWER_RET, >>> .mpu_logic_state = PWRDM_POWER_RET, >>> }, >>> +#if 0 >>> { >>> .cpu_state = PWRDM_POWER_OFF, >>> .mpu_state = PWRDM_POWER_RET, >>> .mpu_logic_state = PWRDM_POWER_OFF, >>> }, >>> +#endif >>> >> >> Hmm, I am afraid that will lead to a fault. Safer to set the state_count = >> 2 instead. > > Hmm don't we have state_count = ARRAY_SIZE(omap4_idle_data) or am I > missing something? > I don't think you are missing anything. The change should work.