All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Scott Feldman <sfeldma@cumulusnetworks.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	netdev <netdev@vger.kernel.org>,
	Vlad Yasevich <vyasevic@redhat.com>,
	john.r.fastabend@intel.com,
	Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH 1/1] iproute2 bridge: bring to par with brctl show macs
Date: Tue, 27 May 2014 17:41:06 -0400	[thread overview]
Message-ID: <53850672.1030107@mojatatu.com> (raw)
In-Reply-To: <27A51C19-553E-4BA0-A8B2-F4251FABA5F4@cumulusnetworks.com>

On 05/27/14 11:59, Scott Feldman wrote:
>
>
> Seems you could use your new kernel filter for brports also, when br is not specified.
>If both br and brport is specified, then use filter in user-space, otherwise use filter
>in kernel on br or brport ifindex.
>

filtering by brport is very useful.
I wasnt as much concerned about that use case because i can already
filter in user space for brport when i dump (iproute2 does as well).
But i couldnt filter by bridge since that info is not even
present in the dumped data
I just saw the patch posted by Roopa - I think that now gives me the
ability to also filter by bridge in user space.

Note: All i am doing is stealing the ndm ifindex - which before was
a zero and ignore by the kernel as the bridge ifindex.
I think what you are suggesting is: if the user doesnt specify the
bridge i should use the ndm ifindex to send down the brport as
the filter. But that becomes an bridge "or" bridgeport filter
choice. A more useful scenario is to have bridge "and"
bridgeport filter. So almost seems like i need an attribute to send
down for the bridge port.
Sounds like a separate patch...

cheers,
jamal

  reply	other threads:[~2014-05-27 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-25 13:22 [PATCH 1/1] iproute2 bridge: bring to par with brctl show macs Jamal Hadi Salim
2014-05-27 15:59 ` Scott Feldman
2014-05-27 21:41   ` Jamal Hadi Salim [this message]
2014-05-27 21:43     ` Jamal Hadi Salim
2014-05-27 23:40       ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53850672.1030107@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.