From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
wkok@cumulusnetworks.com,
Shrijeet Mukherjee <shm@cumulusnetworks.com>
Subject: Re: [RFC PATCH] Add bridge ifindex to bridge fdb notify msgs
Date: Tue, 27 May 2014 17:51:12 -0400 [thread overview]
Message-ID: <538508D0.5050405@mojatatu.com> (raw)
In-Reply-To: <5384C5C6.2090606@cumulusnetworks.com>
On 05/27/14 13:05, Roopa Prabhu wrote:
>> I like the idea of this, but the new attribute needs to be part of the
>> set
>> as well as notify and display infrastructure.
>>
> ok thanks, i will resubmit with set and other changes.
I think it is useful for symettry purposes to have both directions
have NDA_MASTER; but other than that, I dont see any purpose NDA_MASTER
serves. A bridge port is specified on the ndm msg to the kernel.
A bridge port can only belong to one master.
The kernel can deduce that already.
Infact i think specifying the NDA_MASTER may cause problems when
the specified NDA_MASTER is not the bridge to which the bridge port
belongs to....
cheers,
jamal
next prev parent reply other threads:[~2014-05-27 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 4:39 [RFC PATCH] Add bridge ifindex to bridge fdb notify msgs roopa
2014-05-27 16:37 ` Stephen Hemminger
2014-05-27 17:05 ` Roopa Prabhu
2014-05-27 21:51 ` Jamal Hadi Salim [this message]
2014-05-27 21:57 ` Jamal Hadi Salim
2014-05-28 0:05 ` Roopa Prabhu
2014-05-28 0:39 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538508D0.5050405@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.