From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker
Date: Tue, 27 May 2014 20:26:22 -0600 [thread overview]
Message-ID: <5385494E.1070803@kernel.dk> (raw)
In-Reply-To: <CACVXFVM6YYW8N0wpKGchAVpLk72qJiqHwiUg4S4Yv+M+o-B=9g@mail.gmail.com>
On 2014-05-27 19:34, Ming Lei wrote:
> On Wed, May 28, 2014 at 3:35 AM, Jens Axboe <axboe@kernel.dk> wrote:
>> On 05/27/2014 01:21 PM, Christoph Hellwig wrote:
>>> On Tue, May 27, 2014 at 01:17:40PM -0600, Jens Axboe wrote:
>>>> But I think you sent the old one again, not the new variant :-)
>>>
>>> Oh well, next try:
>>
>> This looks good to me. Was trying to think of ways to reduce that to one
>> list iteration, but I think it's cleaner to just retain the two separate
>> ones.
>>
>> Reusing REQ_SOFTBARRIER is fine as well, not used in blk-mq otherwise.
>>
>> Let me know when you have runtime verified it.
>
> Looks writing over ext4(especially sync writing) can survive
> with Christoph's patch now, thanks Christoph.
>
> Reported-and-tested-by: Ming Lei <tom.leiming@gmail.com>
Great! I'll queue it up here too, then.
--
Jens Axboe
next prev parent reply other threads:[~2014-05-28 2:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 15:05 [PATCH] block: mq flush: fix race between IPI handler and mq flush worker Ming Lei
2014-05-19 15:18 ` Christoph Hellwig
2014-05-19 15:34 ` Ming Lei
2014-05-20 3:20 ` Ming Lei
2014-05-20 15:23 ` Christoph Hellwig
2014-05-21 5:16 ` Ming Lei
2014-05-21 5:36 ` Christoph Hellwig
2014-05-21 6:48 ` Ming Lei
2014-05-27 18:13 ` Christoph Hellwig
2014-05-27 18:38 ` Jens Axboe
2014-05-27 18:53 ` Christoph Hellwig
2014-05-27 18:54 ` Jens Axboe
2014-05-27 19:15 ` Christoph Hellwig
2014-05-27 19:17 ` Jens Axboe
2014-05-27 19:21 ` Christoph Hellwig
2014-05-27 19:35 ` Jens Axboe
2014-05-28 1:34 ` Ming Lei
2014-05-28 2:26 ` Jens Axboe [this message]
2014-05-28 2:31 ` Jens Axboe
2014-05-28 5:22 ` Christoph Hellwig
2014-05-28 14:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5385494E.1070803@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.