All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hongxu Jia <hongxu.jia@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: Saul Wold <saul.wold@intel.com>,
	OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] socat: fix linux/errqueue.h not found
Date: Wed, 28 May 2014 13:57:49 +0800	[thread overview]
Message-ID: <53857ADD.50902@windriver.com> (raw)
In-Reply-To: <CAJTo0LZhh6WNn4vyNyzQ_yo9mKqikizb-UkkbUZGsPyN=UzxrQ@mail.gmail.com>

On 05/27/2014 07:43 PM, Burton, Ross wrote:
> On 27 May 2014 02:59, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> +-AC_CHECK_HEADERS(linux/types.h)
>> +-AC_CHECK_HEADER(linux/errqueue.h, AC_DEFINE(HAVE_LINUX_ERRQUEUE_H), [], [#include <linux/types.h>])
>> ++AC_CHECK_HEADERS(linux/types.h linux/errqueue.h)
> Have you checked the config.log and config.h to verify this is actually working?
>
> It looks like you're simply removing the AC_DEFINE of
> HAVE_LINUX_ERRQUEUE_H which is used as a guard around
> <linux/errqueue.h> in sysincludes.h.

I took a look, and found out the 'AC_DEFINE' didn't work,
...
-AC_CHECK_HEADER(linux/errqueue.h, AC_DEFINE(HAVE_LINUX_ERRQUEUE_H), [], 
[#include <linux/types.h>])
+AC_CHECK_HEADER(linux/errqueue.h, AC_DEFINE(HAVE_LINUX_ERRQUEUE_H, [1], 
[With linux errqueue header]), [], [#include <linux/types.h>])
...

The fix was the same with compile.patch, I will merged it to compile.patch.

//Hongxu

> Ross



      reply	other threads:[~2014-05-28  5:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27  1:59 [PATCH V2 0/3] socat: upgrade to 1.7.2.4 Hongxu Jia
2014-05-27  1:59 ` [PATCH 1/3] " Hongxu Jia
2014-05-27 11:37   ` Burton, Ross
2014-05-28  7:28     ` Hongxu Jia
2014-05-27  1:59 ` [PATCH 2/3] socat: fix supporting cross compiling Hongxu Jia
2014-05-27  1:59 ` [PATCH 3/3] socat: fix linux/errqueue.h not found Hongxu Jia
2014-05-27 11:43   ` Burton, Ross
2014-05-28  5:57     ` Hongxu Jia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53857ADD.50902@windriver.com \
    --to=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    --cc=saul.wold@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.