From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Cc: dev.kurt@vandijck-laurijssen.be, fabio.baltieri@gmail.com
Subject: Re: [PATCH] can: only rename enabled led triggers when changing the netdev name
Date: Wed, 28 May 2014 10:06:33 +0200 [thread overview]
Message-ID: <53859909.4090904@pengutronix.de> (raw)
In-Reply-To: <1401190256-2963-1-git-send-email-socketcan@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On 05/27/2014 01:30 PM, Oliver Hartkopp wrote:
> Commit a1ef7bd9fce8 ("can: rename LED trigger name on netdev renames") renames
> the led trigger names according to the changed netdevice name.
>
> As not every CAN driver supports and initializes the led triggers, checking for
> the CAN private datastructure with safe_candev_priv() in the notifier chain is
> not enough.
>
> This patch adds a check when CONFIG_CAN_LEDS is enabled and the driver does not
> support led triggers.
>
> For stable 3.9+
>
> CC: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> CC: Fabio Baltieri <fabio.baltieri@gmail.com>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Applied to can.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-05-28 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 11:30 [PATCH] can: only rename enabled led triggers when changing the netdev name Oliver Hartkopp
2014-05-27 13:00 ` Kurt Van Dijck
2014-05-28 8:06 ` Marc Kleine-Budde [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-28 8:04 pull-request: can 2014-05-28 Marc Kleine-Budde
2014-05-28 8:04 ` [PATCH] can: only rename enabled led triggers when changing the netdev name Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53859909.4090904@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dev.kurt@vandijck-laurijssen.be \
--cc=fabio.baltieri@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.