From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Egger, Christoph" Subject: Re: [PATCH V2] x86, mce: Consolidate AMD mcheck initialization Date: Wed, 28 May 2014 12:02:03 +0200 Message-ID: <5385B41B.8000309@amazon.de> References: <1401203677-16497-1-git-send-email-aravind.gopalakrishnan@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401203677-16497-1-git-send-email-aravind.gopalakrishnan@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Aravind Gopalakrishnan , jinsong.liu@alibaba-inc.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 27.05.14 17:14, Aravind Gopalakrishnan wrote: > amd_k8.c did a lot of common work and very little K8 > specific work. So merge init functions of amd_f10.c and > amd_k8.c and move it into the common amd_mcheck_init > handler. With that done, there is not much left in either > files, so fold all code into just one file - mce_amd.c > > While at it, update the comments regarding documentation > with correct URL's and revision numbers. > > Also, update copyright info. > > Changes in V2: > - Fix coding style issues >>From the functional perspective this patch is fine. Regarding coding style, make Jan happy, then you have my Acked-by: Christoph Egger