diff for duplicates of <5385B764.6090301@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 68a369d..029b8ba 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,7 +20,7 @@ Am 28.05.2014 11:11, schrieb Giedrius Rekasius: > - box = pci_get_drvdata(pdev); > if (!box) { > for (i = 0; i < UNCORE_EXTRA_PCI_DEV_MAX; i++) { -> if (extra_pci_dev[phys_id][i] = pdev) { +> if (extra_pci_dev[phys_id][i] == pdev) { Just a remark, for readability it is better to remove the other one. diff --git a/a/content_digest b/N1/content_digest index eadb99a..54be85b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01401268294-28634-1-git-send-email-giedrius.rekasius@gmail.com\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [PATCH] perf/x86/uncore: Remove unnecessary assignment to \"box\" in uncore_pci_remove(...)\0" - "Date\0Wed, 28 May 2014 10:16:04 +0000\0" + "Date\0Wed, 28 May 2014 12:16:04 +0200\0" "To\0Giedrius Rekasius <giedrius.rekasius@gmail.com>\0" "Cc\0Peter Zijlstra <a.p.zijlstra@chello.nl>" Paul Mackerras <paulus@samba.org> @@ -36,7 +36,7 @@ "> -\tbox = pci_get_drvdata(pdev);\n" "> \tif (!box) {\n" "> \t\tfor (i = 0; i < UNCORE_EXTRA_PCI_DEV_MAX; i++) {\n" - "> \t\t\tif (extra_pci_dev[phys_id][i] = pdev) {\n" + "> \t\t\tif (extra_pci_dev[phys_id][i] == pdev) {\n" "\n" "Just a remark,\n" "for readability it is better to remove the other one.\n" @@ -44,4 +44,4 @@ "re,\n" wh -c3b145778e8d5fa0d4b017f8f5d542a9b56c2abcb9aaecbf54ef9b369277518e +0531badb704c67fe8620365657a7e651139865e07d98436f3795993a93147a23
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.