From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Shawn Guo <shawn.guo@freescale.com>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 1/2] media: mx2-emmaprp: Add devicetree support
Date: Wed, 28 May 2014 12:20:59 +0200 [thread overview]
Message-ID: <5385B88B.6040005@samsung.com> (raw)
In-Reply-To: <1401271373.216160251@f395.i.mail.ru>
On 28/05/14 12:02, Alexander Shiyan wrote:
> Wed, 28 May 2014 11:46:38 +0200 от Sylwester Nawrocki <s.nawrocki@samsung.com>:
>> On 27/05/14 09:47, Alexander Shiyan wrote:
>>> This patch adds devicetree support for the Freescale enhanced Multimedia
>>> Accelerator (eMMA) video Pre-processor (PrP).
>>>
>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ...
>
>> Could you also fix the remaining checkpatch warnings:
>>
>>
>> WARNING: Use a single space after To:
>> #35:
>> To: linux-media@vger.kernel.org
>>
>> WARNING: Use a single space after Cc:
>> #36:
>> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
>>
>> ERROR: DOS line endings
>> #67: FILE: drivers/media/platform/mx2_emmaprp.c:21:
>> +#include <linux/of.h>^M$
> ...
>> [PATCH 1_2] media: mx2-emmaprp: Add devicetree support.eml has style problems, please review.
>
> ...support.eml ?
>
> All of these warnings is a result of email export.
Indeed, sorry about that, should have used my usual script
to check it. This patch is fine then.
--
Thanks,
Sylwester
prev parent reply other threads:[~2014-05-28 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 7:47 [PATCH 1/2] media: mx2-emmaprp: Add devicetree support Alexander Shiyan
2014-05-28 9:46 ` Sylwester Nawrocki
2014-05-28 10:02 ` Alexander Shiyan
2014-05-28 10:20 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5385B88B.6040005@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=shawn.guo@freescale.com \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.