From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type
Date: Wed, 28 May 2014 13:25:40 +0200 [thread overview]
Message-ID: <5385C7B4.7080603@redhat.com> (raw)
In-Reply-To: <1401229304.12413.24.camel@haakon3.risingtidesystems.com>
Il 28/05/2014 00:21, Nicholas A. Bellinger ha scritto:
> On Mon, 2014-05-26 at 13:30 -0400, Martin K. Petersen wrote:
>>>>>>> "Nic" == Nicholas A Bellinger <nab@linux-iscsi.org> writes:
>>
>>>> What about #ifdef'ing VIRTIO_SCSI_F_T10_PI support out if
>>>> !CONFIG_BLK_DEV_INTEGRITY?
>>
>> Nic> I figured it was slightly cleaner to enable BLK_DEV_INTEGRITY by
>> Nic> default when referencing struct blk_integrity (following what
>> Nic> IBLOCK does), than adding the equivalent #ifdef's..
>>
>> Nic> MKP, do you have a preference on this..?
>>
>> Well, I guess how important the virtio stuff is in the embedded space?
>>
>> In the block layer we have all these wrappers that allow things to Do
>> The Right Thing when the BLK_DEV_INTEGRITY is disabled. I'm not entirely
>> sure it worth the hassle to do the same for target and virtio. The
>> memory savings aren't that big to begin with.
>>
>> And besides, the bip pointer field in struct bio is about to become
>> generic with my impending copy offload patches anyway,
>>
>
> In that case, I'll leave as is unless Paolo has an objection.
No, that's fine.
Paolo
prev parent reply other threads:[~2014-05-28 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <537d6b74.lQGMmmapPq/MP5Nx%fengguang.wu@intel.com>
2014-05-22 20:46 ` [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type Nicholas A. Bellinger
2014-05-23 9:20 ` Paolo Bonzini
2014-05-23 17:45 ` Nicholas A. Bellinger
2014-05-26 17:30 ` Martin K. Petersen
2014-05-27 22:21 ` Nicholas A. Bellinger
2014-05-28 11:25 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5385C7B4.7080603@redhat.com \
--to=pbonzini@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.