Re: [PATCH 4/8] ARM: shmobile: lager: Add dummy PCIe bus clock

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 05/28/2014 07:04 PM, Phil Edworthy wrote:

>>> Since the CPU's dtsi refers to pcie_bus_clock, we need an entry in
>>> the board's dts, even if we aren't using PCIe.

>>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
>>> ---
>>>    arch/arm/boot/dts/r8a7790-lager.dts | 10 ++++++++++
>>>    1 file changed, 10 insertions(+)

>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
>> b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 9becef7..6d4fe97 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -144,6 +144,16 @@
>>>    		states = <3300000 1
>>>    			  1800000 0>;
>>>    	};
>>> +
>>> +	clocks {
>>> +		/* External PCIe bus clock - not used */
>>> +		pcie_bus_clk: pcie_bus_clk {
>>> +			compatible = "fixed-clock";
>>> +			#clock-cells = <0>;
>>> +			clock-frequency = <0>;

>>      When this value gets filled in?

> It doesn't. On the Lager board, there is no PCIe support.

> It's needed as pcie_bus_clk is referenced from r8a7790.dtsi and without it
> you'll get build failures.

    Yeah, I've figured that out after sending that email. Perhaps it makes 
sense to stub this clock in the SoC's .dtsi file alike the EXTAL clock?

> Cheers
> Phil

WBR, Sergei