From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD).
Date: Wed, 28 May 2014 13:40:04 -0700 [thread overview]
Message-ID: <538649A4.2020208@linux.intel.com> (raw)
In-Reply-To: <1401281903-25143-1-git-send-email-indraneel.m@samsung.com>
On 05/28/2014 05:58 AM, Indraneel Mukherjee wrote:
>
Could there be an intro/description to this patch like there is for all
the other patches I've seen on this list, please (Keith's patch sent
yesterday could be an example)? Thanks!
> diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
> index da3b252..0d9805b 100644
> --- a/drivers/block/nvme-scsi.c
> +++ b/drivers/block/nvme-scsi.c
> @@ -1014,8 +1014,8 @@ static int nvme_trans_log_info_exceptions(struct nvme_ns *ns,
> c.common.opcode = nvme_admin_get_log_page;
> c.common.nsid = cpu_to_le32(0xFFFFFFFF);
> c.common.prp1 = cpu_to_le64(dma_addr);
> - c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
> - BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
> + c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
> + BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
> res = nvme_submit_admin_cmd(dev, &c, NULL);
> if (res != NVME_SC_SUCCESS) {
> temp_c = LOG_TEMP_UNKNOWN;
> @@ -1082,8 +1082,8 @@ static int nvme_trans_log_temperature(struct nvme_ns *ns, struct sg_io_hdr *hdr,
> c.common.opcode = nvme_admin_get_log_page;
> c.common.nsid = cpu_to_le32(0xFFFFFFFF);
> c.common.prp1 = cpu_to_le64(dma_addr);
> - c.common.cdw10[0] = cpu_to_le32(((sizeof(struct nvme_smart_log) /
> - BYTES_TO_DWORDS) << 16) | NVME_GET_SMART_LOG_PAGE);
> + c.common.cdw10[0] = cpu_to_le32((((sizeof(struct nvme_smart_log) /
> + BYTES_TO_DWORDS)-1) << 16) | NVME_GET_SMART_LOG_PAGE);
> res = nvme_submit_admin_cmd(dev, &c, NULL);
> if (res != NVME_SC_SUCCESS) {
> temp_c_cur = LOG_TEMP_UNKNOWN;
>
prev parent reply other threads:[~2014-05-28 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 12:58 [PATCH] Fix log page buffer size passed in GetLogPage(CDW10.NUMD) Indraneel Mukherjee
2014-05-28 16:40 ` Vishal Verma
2014-05-28 20:40 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538649A4.2020208@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.