From: Tony Jones <tonyj@suse.de>
To: linux-audit@redhat.com
Cc: seth.arnold@canonical.com, wpreston@suse.com
Subject: [PATCH] userspace: audit: ausearch doesn't return entries for AppArmor events that exist in the log
Date: Wed, 28 May 2014 15:33:06 -0700 [thread overview]
Message-ID: <53866422.5010709@suse.de> (raw)
This patch came from our L3 department. AppArmor LSM is logging using the common_lsm_audit()
call but the audit userspace parsing code expects to see an SELinux tclass field. This patch
doesn't address the lack of support for AppArmor in "aureport --avc". Talking to Seth Arnold,
Canonical apparently has patches for this; if this is true perhaps they can post for inclusion.
Based-on-work-by: William Preston <wpreston@suse.com>
Signed-off-by: Tony Jones <tonyj@suse.de>
--- a/src/ausearch-parse.c 2014-05-21 14:45:22.000000000 +0200
+++ b/src/ausearch-parse.c 2014-05-21 14:53:55.000000000 +0200
@@ -1735,17 +1735,15 @@ static int parse_avc(const lnode *n, sea
// Now get the class...its at the end, so we do things different
str = strstr(term, "tclass=");
- if (str == NULL) {
- rc = 9;
- goto err;
+ if (str) {
+ str += 7;
+ term = strchr(str, ' ');
+ if (term)
+ *term = 0;
+ an.avc_class = strdup(str);
+ if (term)
+ *term = ' ';
}
- str += 7;
- term = strchr(str, ' ');
- if (term)
- *term = 0;
- an.avc_class = strdup(str);
- if (term)
- *term = ' ';
if (audit_avc_init(s) == 0) {
alist_append(s->avc, &an);
next reply other threads:[~2014-05-28 22:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 22:33 Tony Jones [this message]
2014-05-29 8:31 ` [PATCH] userspace: audit: ausearch doesn't return entries for AppArmor events that exist in the log Tyler Hicks
2014-05-29 15:01 ` Steve Grubb
2014-05-29 15:15 ` Tyler Hicks
2014-06-03 1:00 ` Tony Jones
2014-06-03 14:47 ` Steve Grubb
2014-06-03 16:34 ` Tony Jones
2014-05-29 15:21 ` Tyler Hicks
2014-05-30 19:53 ` Steve Grubb
2014-05-30 20:16 ` Tyler Hicks
2014-05-30 21:00 ` Steve Grubb
2014-05-31 0:01 ` Tony Jones
2014-06-06 18:46 ` Tyler Hicks
2014-06-06 21:10 ` Tyler Hicks
2014-06-24 0:06 ` Tony Jones
2014-06-24 15:34 ` Eric Paris
-- strict thread matches above, loose matches on Subject: below --
2016-04-29 7:03 Vincas Dargis
2016-04-29 13:39 ` Steve Grubb
2016-04-29 16:07 ` Vincas Dargis
2016-04-29 16:30 ` Steve Grubb
2016-05-02 21:18 ` Paul Moore
2016-04-29 15:41 ` Richard Guy Briggs
2016-04-29 16:58 ` Vincas Dargis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53866422.5010709@suse.de \
--to=tonyj@suse.de \
--cc=linux-audit@redhat.com \
--cc=seth.arnold@canonical.com \
--cc=wpreston@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.