All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Exynos: Make sure ps_hold gets set in the SPL
Date: Thu, 29 May 2014 10:06:11 +0900	[thread overview]
Message-ID: <53868803.5020609@samsung.com> (raw)
In-Reply-To: <1401112281-9334-1-git-send-email-akshay.s@samsung.com>

Dear Akshay Saraswat,

On 26/05/14 22:51, Akshay Saraswat wrote:
> From: Doug Anderson <dianders@chromium.org>
> 
> Setting ps_hold ought to be one of the first things we do when we
> first boot up. If we wait until the main u-boot runs we won't set it
> in time and the PMIC may power us back off.
> 
> Moving ps_hold setup into the generic power_init() which
> should contain code that's currently duplicated in the
> board_power_init() of several boards.
> 
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
> Changes since v1:
> 	- Added "Acked-by".
> 
>  arch/arm/cpu/armv7/exynos/lowlevel_init.c |    6 +++++-
>  arch/arm/cpu/armv7/exynos/power.c         |   14 ++++++++++++++
>  arch/arm/include/asm/arch-exynos/power.h  |    8 ++++++++
>  3 files changed, 27 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/armv7/exynos/lowlevel_init.c b/arch/arm/cpu/armv7/exynos/lowlevel_init.c
> index 11fe5b8..ed966bc 100644
> --- a/arch/arm/cpu/armv7/exynos/lowlevel_init.c
> +++ b/arch/arm/cpu/armv7/exynos/lowlevel_init.c
> @@ -39,6 +39,7 @@ enum {
>  	DO_CLOCKS	= 1 << 1,
>  	DO_MEM_RESET	= 1 << 2,
>  	DO_UART		= 1 << 3,
> +	DO_POWER	= 1 << 4,
>  };
>  
>  int do_lowlevel_init(void)
> @@ -60,9 +61,12 @@ int do_lowlevel_init(void)
>  		break;
>  	default:
>  		/* This is a normal boot (not a wake from sleep) */
> -		actions = DO_CLOCKS | DO_MEM_RESET;
> +		actions = DO_CLOCKS | DO_MEM_RESET | DO_POWER;
>  	}
>  
> +	if (actions & DO_POWER)
> +		power_init();

I think we don't have to make new function.
Please call set_ps_hold_ctrl directly.

Thanks,
Minkyu Kang.

      reply	other threads:[~2014-05-29  1:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 13:51 [U-Boot] [PATCH v2] Exynos: Make sure ps_hold gets set in the SPL Akshay Saraswat
2014-05-29  1:06 ` Minkyu Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53868803.5020609@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.