All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	SH-Linux <linux-sh@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers
Date: Thu, 29 May 2014 01:24:04 +0000	[thread overview]
Message-ID: <53868C34.9000309@renesas.com> (raw)
In-Reply-To: <20140528202607.GA7537@kroah.com>

Hi,

(2014/05/29 5:26), Greg Kroah-Hartman wrote:
> On Wed, May 28, 2014 at 08:23:09PM +0900, Yoshihiro Shimoda wrote:
< snip >
>> +#define FIRMWARE_NAME		"r8a779x_usb3_v1.dlmem"
> 
> Shouldn't you also add a:
> 	MODULE_FIRMWARE(FIRMWARE_NAME);
> line to this file so that the automatic tools can pick it up properly?

Thank you for the point! I will add it.

Best regards,
Yoshihiro Shimoda

> thanks,
> 
> greg k-h
> 

-- 
Yoshihiro Shimoda
EC No.

WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	SH-Linux <linux-sh@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers
Date: Thu, 29 May 2014 10:24:04 +0900	[thread overview]
Message-ID: <53868C34.9000309@renesas.com> (raw)
In-Reply-To: <20140528202607.GA7537@kroah.com>

Hi,

(2014/05/29 5:26), Greg Kroah-Hartman wrote:
> On Wed, May 28, 2014 at 08:23:09PM +0900, Yoshihiro Shimoda wrote:
< snip >
>> +#define FIRMWARE_NAME		"r8a779x_usb3_v1.dlmem"
> 
> Shouldn't you also add a:
> 	MODULE_FIRMWARE(FIRMWARE_NAME);
> line to this file so that the automatic tools can pick it up properly?

Thank you for the point! I will add it.

Best regards,
Yoshihiro Shimoda

> thanks,
> 
> greg k-h
> 

-- 
Yoshihiro Shimoda
EC No.

  reply	other threads:[~2014-05-29  1:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-28 11:23 [PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers Yoshihiro Shimoda
2014-05-28 11:23 ` Yoshihiro Shimoda
     [not found] ` <5385C71D.5060509-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-05-28 20:26   ` Greg Kroah-Hartman
2014-05-28 20:26     ` Greg Kroah-Hartman
2014-05-29  1:24     ` Yoshihiro Shimoda [this message]
2014-05-29  1:24       ` Yoshihiro Shimoda
2014-05-28 20:28 ` Greg Kroah-Hartman
2014-05-28 20:28   ` Greg Kroah-Hartman
     [not found]   ` <20140528202849.GA14248-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-05-29  1:24     ` Yoshihiro Shimoda
2014-05-29  1:24       ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53868C34.9000309@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mathias.nyman@intel.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.