From: Junxiao Bi <junxiao.bi@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: joe.jin@oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: xfs_copy: fix data corruption of target
Date: Thu, 29 May 2014 09:46:17 +0800 [thread overview]
Message-ID: <53869169.5070203@oracle.com> (raw)
In-Reply-To: <20140528053241.GC3816@infradead.org>
On 05/28/2014 01:32 PM, Christoph Hellwig wrote:
> On Wed, May 28, 2014 at 11:28:07AM +0800, Junxiao Bi wrote:
>> The unit of XFS_AGFL_DADDR(mp) is "basic block" whose size is "BBSIZE"
>> (512 bytes), so when "source_sectorsize" is not 512, it will cause the
>> target a corrupted filesystem.
>>
>> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
> Looks good. Any chance you could create a testcase for this as well?
I will try. Thank you for review it.
Thanks,
Junxiao.
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-29 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 3:28 [PATCH] xfsprogs: xfs_copy: fix data corruption of target Junxiao Bi
2014-05-28 5:32 ` Christoph Hellwig
2014-05-29 1:46 ` Junxiao Bi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53869169.5070203@oracle.com \
--to=junxiao.bi@oracle.com \
--cc=hch@infradead.org \
--cc=joe.jin@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.