From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, xfs@oss.sgi.com
Subject: Re: xfs: possible deadlock warning
Date: Thu, 29 May 2014 11:34:21 +0800 [thread overview]
Message-ID: <5386AABD.5070708@cn.fujitsu.com> (raw)
In-Reply-To: <20140528060050.GK8554@dastard>
Hi Dave,
On 05/28/2014 02:00 PM, Dave Chinner wrote:
> On Wed, May 28, 2014 at 01:19:16PM +0800, Gu Zheng wrote:
>> Hi all,
>> When running the latest Linus' tree, the following possible deadlock warning occurs.
>
> false positive. There isn't a deadlock between inode locks on
> different filesystems. i.e. there is no dependency between shmem
> inodes and xfs inodes, nor on their security contexts. Nor can you
> take a page fault on a directory inode, which is the XFS inode lock
> class it's complaining about.
If it's really a noisy, can we avoid this?
Thanks,
Gu
>
> Fundamentally, the problem here is shmem instantiating a new inode
> with the mmap_sem held. That's just plain wrong...
Agree, it's better to prepare the file before going into the protection region.
>
>
> Cheers,
>
> Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Dave Chinner <david@fromorbit.com>
Cc: <xfs@oss.sgi.com>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: xfs: possible deadlock warning
Date: Thu, 29 May 2014 11:34:21 +0800 [thread overview]
Message-ID: <5386AABD.5070708@cn.fujitsu.com> (raw)
In-Reply-To: <20140528060050.GK8554@dastard>
Hi Dave,
On 05/28/2014 02:00 PM, Dave Chinner wrote:
> On Wed, May 28, 2014 at 01:19:16PM +0800, Gu Zheng wrote:
>> Hi all,
>> When running the latest Linus' tree, the following possible deadlock warning occurs.
>
> false positive. There isn't a deadlock between inode locks on
> different filesystems. i.e. there is no dependency between shmem
> inodes and xfs inodes, nor on their security contexts. Nor can you
> take a page fault on a directory inode, which is the XFS inode lock
> class it's complaining about.
If it's really a noisy, can we avoid this?
Thanks,
Gu
>
> Fundamentally, the problem here is shmem instantiating a new inode
> with the mmap_sem held. That's just plain wrong...
Agree, it's better to prepare the file before going into the protection region.
>
>
> Cheers,
>
> Dave.
next prev parent reply other threads:[~2014-05-29 3:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 5:19 xfs: possible deadlock warning Gu Zheng
2014-05-28 5:19 ` Gu Zheng
2014-05-28 6:00 ` Dave Chinner
2014-05-28 6:00 ` Dave Chinner
2014-05-29 3:34 ` Gu Zheng [this message]
2014-05-29 3:34 ` Gu Zheng
2014-05-29 7:49 ` Dave Chinner
2014-05-29 7:49 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5386AABD.5070708@cn.fujitsu.com \
--to=guz.fnst@cn.fujitsu.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.