All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 11/11] imx: ventana: switch to SPL
Date: Thu, 29 May 2014 09:02:24 +0200	[thread overview]
Message-ID: <5386DB80.1000703@denx.de> (raw)
In-Reply-To: <1399526182-11966-12-git-send-email-tharvey@gateworks.com>

Hi Tim,

I cannot build with this version. A setup for a couple of pins is not
yet replaces.

In fact, I have:

        /* Enable Backlight */
       imx_iomux_v3_setup_pad(MX6_PAD_SD1_CMD__GPIO1_IO18 |

and it should be:

 SETUP_IOMUX_PAD(PAD_SD1_CMD__GPIO1_IO18 |

The same some lines later:

        /* Backlight CABEN on LVDS connector */
-       imx_iomux_v3_setup_pad(MX6_PAD_SD2_CLK__GPIO1_IO10 |
+       SETUP_IOMUX_PAD(PAD_SD2_CLK__GPIO1_IO10 |


Can you check and fix it ? Thanks !

Regarding your patchset: I had no remarkable comments and, as I have not
seen any comments from other developers, your patchset is ready to be
merged. I am also waiting for Masahiro's patch to be applied.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-05-29  7:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  5:16 [U-Boot] [PATCH v3 00/11] mx6: SPL NAND support Tim Harvey
2014-05-08  5:16 ` [U-Boot] [PATCH v3 01/11] nand: remove CONFIG_SYS_NAND_PAGE_SIZE Tim Harvey
2014-05-14  8:52   ` Masahiro Yamada
2014-05-14 10:14     ` Stefano Babic
2014-05-15  8:31   ` Stefano Babic
2014-05-08  5:16 ` [U-Boot] [PATCH v3 02/11] spl: nand: add support for mxs nand Tim Harvey
2014-05-08  5:16 ` [U-Boot] [PATCH v3 03/11] mx6: add common SPL configuration Tim Harvey
2014-05-08  5:16 ` [U-Boot] [PATCH v3 04/11] mx6: add boot device support for SPL Tim Harvey
2014-05-28 16:38   ` Nikita Kiryanov
2014-05-29  4:11     ` Tim Harvey
2014-05-29  6:45       ` Igor Grinberg
2014-05-08  5:16 ` [U-Boot] [PATCH v3 05/11] imx: add comments and remove unused struct fields Tim Harvey
2014-05-28 16:38   ` Nikita Kiryanov
2014-05-08  5:16 ` [U-Boot] [PATCH v3 06/11] mx6: add structs for mmdc and ddr iomux registers Tim Harvey
2014-05-28 17:06   ` Nikita Kiryanov
2014-05-29  4:16     ` Tim Harvey
2014-05-29  6:48       ` Stefano Babic
2014-05-29  7:20         ` Nikita Kiryanov
2014-05-08  5:16 ` [U-Boot] [PATCH v3 07/11] mx6: add mmdc configuration for MX6Q/MX6DL Tim Harvey
2014-05-22 22:28   ` [U-Boot] [PATCH v4 " Tim Harvey
2014-05-08  5:16 ` [U-Boot] [PATCH v3 08/11] imx: iomux: add macros to setup iomux for multiple SoC types Tim Harvey
2014-05-08  5:16 ` [U-Boot] [PATCH v3 09/11] imx: ventana: split read_eeprom into standalone file Tim Harvey
2014-05-08  5:16 ` [U-Boot] [PATCH v3 10/11] imx: ventana: auto-configure for IMX6Q vs IMX6DL Tim Harvey
2014-05-08  5:16 ` [U-Boot] [PATCH v3 11/11] imx: ventana: switch to SPL Tim Harvey
2014-05-29  7:02   ` Stefano Babic [this message]
2014-05-30  4:52     ` Tim Harvey
2014-05-30  7:36       ` Stefano Babic
2014-05-22  6:14 ` [U-Boot] [PATCH v3 00/11] mx6: SPL NAND support Tim Harvey
2014-05-22  6:34   ` Stefano Babic
2014-05-22 22:17     ` Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5386DB80.1000703@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.