From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aravind Gopalakrishnan Subject: Re: [PATCH V3] x86, mce: Consolidate AMD mcheck initialization Date: Thu, 29 May 2014 11:31:26 -0500 Message-ID: <538760DE.5060503@amd.com> References: <1401292355-3882-1-git-send-email-aravind.gopalakrishnan@amd.com> <53876DC202000078000B52FA@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53876DC202000078000B52FA@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , chegger@amazon.de, xen-devel@lists.xen.org Cc: jinsong.liu@alibaba-inc.com List-Id: xen-devel@lists.xenproject.org On 5/29/2014 11:26 AM, Jan Beulich wrote: >>>> Aravind Gopalakrishnan 05/28/14 5:55 PM >>> >> amd_k8.c did a lot of common work and very little K8 >> specific work. So merge init functions of amd_f10.c and >> amd_k8.c and move it into the common amd_mcheck_init >> handler. With that done, there is not much left in either >> files, so fold all code into just one file - mce_amd.c >> >> While at it, update the comments regarding documentation >> with correct URL's and revision numbers. >> >> Also, update copyright info. >> >> Changes in V2: > >- Fix coding style issues >> Changes in V3: > >- More coding style fixes. >> Signed-off-by: Aravind Gopalakrishnan > Looks like you lost Christoph's ack - everything else looks fine now. > > Yeah.was unsure of adding it just in case I missed something and had to spin another patch. Figured if everything is OK, then you could add it while committing :) Thanks, -Aravind.