From: Stephen Warren <swarren@wwwdotorg.org>
To: fwu@marvell.com, linus.walleij@linaro.org, tony@atomide.com
Cc: linux-kernel@vger.kernel.org, swarren@nvidia.com,
cxie4@marvell.com, ylmao@marvell.com, njiang1@marvell.com,
tianxf@marvell.com, fswu@marvell.com
Subject: Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin
Date: Thu, 29 May 2014 13:19:05 -0600 [thread overview]
Message-ID: <53878829.4050703@wwwdotorg.org> (raw)
In-Reply-To: <1401072217-3180-1-git-send-email-fwu@marvell.com>
On 05/25/2014 08:43 PM, fwu@marvell.com wrote:
> From: Fan Wu <fwu@marvell.com>
>
> What the patch did:
> 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of
> calling pinctrl_select_state
> 2.Remove the HW disable operation in in pinmux_disable_setting function.
...
This commit description is way too long for such a simple change. A much
shorter summary would be better.
> Signed-off-by: Fan Wu <fwu@marvell.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
I'm pretty sure I never signed off on this patch. How come my s-o-b line
is there?
This patch still doesn't remove ops->disable from the struct pinmux_ops,
nor any of its implementations. Shouldn't it?
next prev parent reply other threads:[~2014-05-29 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 2:43 [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin fwu
2014-05-26 2:52 ` FanWu
2014-05-29 2:55 ` FanWu
2014-05-29 19:19 ` Stephen Warren [this message]
2014-05-30 2:27 ` FanWu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53878829.4050703@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=cxie4@marvell.com \
--cc=fswu@marvell.com \
--cc=fwu@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=njiang1@marvell.com \
--cc=swarren@nvidia.com \
--cc=tianxf@marvell.com \
--cc=tony@atomide.com \
--cc=ylmao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.