All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: dros@primarydata.com,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: linux-next build failure on m68k in nfs code
Date: Thu, 29 May 2014 15:40:35 -0400	[thread overview]
Message-ID: <53878D33.80107@windriver.com> (raw)

Hi Trond,

I'm seeing this on today's linux-next with m68k allmodconfig:

ERROR: "__umoddi3" [fs/nfs/nfs_layout_nfsv41_files.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Making this obviously incorrect change makes it go away:


        /* calculate remaining bytes in the current stripe */
-       stripe_offset = ((u64)req_offset(req) - segment_offset) % stripe_unit;
+       stripe_offset = 0; // ((u64)req_offset(req) - segment_offset) % stripe_unit;


The line above comes from:

commit fa1165eda0eeaee57c292df3af1c98e10223f0f5
Author: Weston Andros Adamson <dros@primarydata.com>
Date:   Thu May 15 11:56:56 2014 -0400

    pnfs: filelayout: support non page aligned layouts

Looks like it needs to use the proper 64bit math wrappers.

Thanks,
Paul.

             reply	other threads:[~2014-05-29 19:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 19:40 Paul Gortmaker [this message]
2014-05-29 20:32 ` linux-next build failure on m68k in nfs code Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53878D33.80107@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=dros@primarydata.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-next@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.