From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: myungjoo.ham@samsung.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] extcon: arizona: Correct typo to disable regulation for button detection
Date: Fri, 30 May 2014 10:31:29 +0900 [thread overview]
Message-ID: <5387DF71.2020807@samsung.com> (raw)
In-Reply-To: <1401377274-10249-4-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On 05/30/2014 12:27 AM, Charles Keepax wrote:
> We can use the bypass mode on the MICVDD reg for button detection, as
> the comment in the code states, however the code was mistakenly
> disabling bypass. This patch corrects this and allows bypass mode during
> button detection.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index c1c8647..b2770aa 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -826,7 +826,7 @@ static void arizona_micd_detect(struct work_struct *work)
> ret);
>
> /* Don't need to regulate for button detection */
> - ret = regulator_allow_bypass(info->micvdd, false);
> + ret = regulator_allow_bypass(info->micvdd, true);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to bypass MICVDD: %d\n",
> ret);
>
Applied.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2014-05-30 1:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 15:27 [PATCH 1/4] extcon: arizona: Remove duplicate set of input parent device Charles Keepax
2014-05-29 15:27 ` [PATCH 2/4] extcon: arizona: Use extcon cable API Charles Keepax
2014-05-30 1:25 ` Chanwoo Choi
2014-05-29 15:27 ` [PATCH 3/4] extcon: arizona: Update manual headphone detection calculation Charles Keepax
2014-05-30 1:27 ` Chanwoo Choi
2014-05-30 9:42 ` Charles Keepax
2014-05-29 15:27 ` [PATCH 4/4] extcon: arizona: Correct typo to disable regulation for button detection Charles Keepax
2014-05-30 1:31 ` Chanwoo Choi [this message]
2014-05-30 1:18 ` [PATCH 1/4] extcon: arizona: Remove duplicate set of input parent device Chanwoo Choi
2014-05-30 1:25 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5387DF71.2020807@samsung.com \
--to=cw00.choi@samsung.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.