From: Nathan Neulinger <nneul@neulinger.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: feature request - implement a "GIT_AUTHOR_EMAIL" equivalent, but processed BEFORE .gitconfig
Date: Fri, 30 May 2014 13:44:05 -0500 [thread overview]
Message-ID: <5388D175.3060500@neulinger.org> (raw)
In-Reply-To: <20140530182746.GK12314@google.com>
> I wouldn't mind having a GIT_EMAIL envvar with the semantics you mean,
> but can you say more about the use case? What's wrong with the usual
> EMAIL environment variable?
EMAIL actually worked for this case for me, but there wasn't any equivalent for author name, so the commits all look
like "sharedaccount <myuser@mydomain>".
> [...]
>> [include]
>> path = !/usr/local/bin/gen-git-env
>
> This is scary in terms of privilege escalation attacks. ("Admin,
> could you please take a look at this repo? When I run 'git status',
> ...".)
Wouldn't that be pulling from ~sharedaccount/.gitconfig anyway though? (Agreed that it could be an issue if you have
shared ssh agent, krb5 tgts, etc. - but that would exist any time you connected into a shared account.)
I would probably take the approach of not supporting that syntax in anything other than the per-user gitconfig file
though as a safety measure - per-repo config could indeed be a problem.
-- Nathan
------------------------------------------------------------
Nathan Neulinger nneul@neulinger.org
Neulinger Consulting (573) 612-1412
next prev parent reply other threads:[~2014-05-30 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 18:19 feature request - implement a "GIT_AUTHOR_EMAIL" equivalent, but processed BEFORE .gitconfig Nathan Neulinger
2014-05-30 18:27 ` Jonathan Nieder
2014-05-30 18:44 ` Nathan Neulinger [this message]
2014-05-30 19:48 ` Junio C Hamano
2014-05-30 19:58 ` Nathan Neulinger
2014-05-30 20:09 ` Jeff King
2014-05-30 21:35 ` Junio C Hamano
2014-06-02 6:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5388D175.3060500@neulinger.org \
--to=nneul@neulinger.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.