All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] cmd_mmc: default to HW partition 0 if not specified
Date: Fri, 30 May 2014 15:11:44 -0600	[thread overview]
Message-ID: <5388F410.7010300@wwwdotorg.org> (raw)
In-Reply-To: <1400870891-14655-1-git-send-email-swarren@wwwdotorg.org>

On 05/23/2014 12:48 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Currently, "mmc dev 0" does not change the selected HW partition. I
> think it makes more sense if "mmc dev 0" is an alias for "mmc dev 0 0",
> i.e. that HW partition 0 (main data area) is always selected by default
> if the user didn't request a specific partition. Otherwise, the following
> happens, which feels wrong:
> 
> Select HW partition 1 (boot0):
> mmc dev 0 1
> 
> Doesn't change the HW partition, so it's still 1 (boot0):
> mmc dev 0
> 
> With this patch, the second command above re-selects the main data area.
> 
> Note that some MMC devices (i.e. SD cards) don't support HW partitions.
> However, this patch still works, since mmc_start_init() sets the current
> partition number to 0, and mmc_select_hwpart() succeeds if the requested
> partition is already selected.

Pantelis, does this series look good?

  parent reply	other threads:[~2014-05-30 21:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 18:48 [U-Boot] [PATCH 1/2] cmd_mmc: default to HW partition 0 if not specified Stephen Warren
2014-05-23 18:48 ` [U-Boot] [PATCH 2/2] disk: " Stephen Warren
2014-06-12 11:23   ` Pantelis Antoniou
2014-05-30 21:11 ` Stephen Warren [this message]
2014-06-10 16:00   ` [U-Boot] [PATCH 1/2] cmd_mmc: " Stephen Warren
2014-06-12 11:21 ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5388F410.7010300@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.