All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Clemens Ladisch <clemens@ladisch.de>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [RFC] [PATCH] firewire-lib: Use IEC 61883-6 compliant labels for Raw Audio/
Date: Sat, 31 May 2014 16:51:52 +0900	[thread overview]
Message-ID: <53898A18.4050902@sakamocchi.jp> (raw)
In-Reply-To: <5389862F.7060309@ladisch.de>

(May 31 2014 16:35), Clemens Ladisch wrote:
> Takashi Sakamoto wrote:
>> I don't touch this label issue with my patchset because there is a bit
>> possibility to cause a regression. But now, I have a confidence that
>> this modification is reasonable. In detail, please see an attached patch.
> 
>> According to AM824 in IEC 61883-6:2002, 2 bits in LSB of label for Raw Audio
>> data means Valid Length Code (VBL). Ths value is:
>> - b00 for 24 bits sample (label is 0x40)
>> - b01 for 20 bits sample (label is 0x41)
>> - b10 for 16 bits sample (label is 0x42)
>>
>> But current firewire-lib apply 24 bits label for both of 16/24 bits samples.
>>
>> As long as I investigate with BeBoB/Fireworks and OXFW, all of them have a
>> behaviour to ignore this label
> 
> Same for DICE.

It's nice information for Dice developers.

> Acked-by: Clemens Ladisch <clemens@ladisch.de>

Thanks.

Iwai-san, could you please apply this patch to for-next?


Regards

Takashi Sakamoto
o-takashi@sakamocchi.jp

  reply	other threads:[~2014-05-31  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31  7:15 [RFC] [PATCH] firewire-lib: Use IEC 61883-6 compliant labels for Raw Audio/ Takashi Sakamoto
2014-05-31  7:35 ` Clemens Ladisch
2014-05-31  7:51   ` Takashi Sakamoto [this message]
2014-06-01  6:23     ` Takashi Iwai
2014-06-01 15:07       ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53898A18.4050902@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.