Re: [PATCH] IIO: Support for True/Magnetic north

[Jonathan Cameron <jic23@kernel.org>]

On 27/05/14 16:34, Srinivas Pandruvada wrote:
> Hi Reyad,
>
> On 05/26/2014 08:20 PM, Reyad Attiyat wrote:
>> Hey Jonathan and Srinivas,
>>
>> I have added in the needed magn_north iio sysfs attributes to the documentation.
>> I hope I did everything correct.
>> I noticed that the line length was very long as compensated is a  fairly long word.
>> I'm thinking I could shorten some of the sysfs paths or shorten the name.
>>
>> For updating the hid-sensor-magn-3d do you have any tips on this? I'm thinking I'll need a
>> dynamic iio_chan array that is passed to iio_register function. It would need to
>> be dynamic in the sense it would only add channels if it found x, y, z, or one of
>> the north attributes. I'll start working on this soon.
>
> I think you mean dynamic " iio_chan_spec magn_3d_channels[]". Currently this is a
> constant. So we can change this to add only channel, which are available.
>
> Also your other changes must be submitted as series of patches, including the drivers using them.
I specifically requested that Reyad get the proposal out asap so that we could discuss it
'before' the patch series using it.  Obviously it won't get merged until there is
a driver using this interface, but often the interface discussion takes longer
than the review of the code so best to get it going asap!
>
> Thanks,
> Srinivas
>
>> Thank You,
>> Reyad Attiyat
>>
>>
>>
>> Reyad Attiyat (1):
>>    IIO: Added iio magn_north ABI documentation
>>
>>   Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++
>>   1 file changed, 76 insertions(+)
>>
>