From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED
Date: Sun, 01 Jun 2014 02:48:18 +0200
Message-ID: <538A7852.8080403@gmail.com>
References: <1401400700-3725-1-git-send-email-tjakobi@math.uni-bielefeld.de>
 <1401400700-3725-2-git-send-email-tjakobi@math.uni-bielefeld.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8A8B96E1B8
 for <dri-devel@lists.freedesktop.org>; Sat, 31 May 2014 17:48:33 -0700 (PDT)
Received: by mail-wg0-f42.google.com with SMTP id y10so3500342wgg.25
 for <dri-devel@lists.freedesktop.org>; Sat, 31 May 2014 17:48:32 -0700 (PDT)
In-Reply-To: <1401400700-3725-2-git-send-email-tjakobi@math.uni-bielefeld.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Tobias,

First of all, thanks for spotting those issues and sending patches.

However looking at libdrm repo history, your patches don't seem to
follow formatting guidelines used there: they lack commit messages
(which should say what is changed and why) and your signed-off-by tags.

Also it is usually a good idea to include respective maintainers on Cc
list, although  unfortunately I'm not sure who would that be in case of
libdrm.

One more comment inline.

On 29.05.2014 23:58, Tobias Jakobi wrote:
> ---
>  exynos/fimg2d.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exynos/fimg2d.h b/exynos/fimg2d.h
> index 1aac378..bc45ab5 100644
> --- a/exynos/fimg2d.h
> +++ b/exynos/fimg2d.h
> @@ -25,7 +25,7 @@
>  #define G2D_MAX_CMD_LIST_NR	64
>  #define G2D_PLANE_MAX_NR	2
>  
> -#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)(d) * 65536.0)
> +#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)(d * 65536.0))

You should also keep the parentheses around d, so that the macro
evaluates correctly even if an expression is passed as the argument.

Best regards,
Tomasz