All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tam3517: fix NAND detection
Date: Mon, 02 Jun 2014 09:22:16 +0200	[thread overview]
Message-ID: <538C2628.4090609@denx.de> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAF215E@DBDE04.ent.ti.com>

Hi Gupta,

On 02/06/2014 08:16, Gupta, Pekon wrote:
>> From: Jeroen Hofstee
>>
>> commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for
>> all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND
>> to be set to access flash. Add CONFIG_NAND for tam3517 derived
>> boards to prevent the following error: "nand: error: Unable to
>> find NAND settings in GPMC Configuration - quitting"
>>
>> cc: Stefano Babic <sbabic@denx.de>
>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>> ---
>> include/configs/tam3517-common.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
>> index 3522c1a..bd117d5 100644
>> --- a/include/configs/tam3517-common.h
>> +++ b/include/configs/tam3517-common.h
>> @@ -185,6 +185,7 @@
>> /* Configure the PISMO */
>> #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
>>
>> +#define CONFIG_NAND
> 
> You should not add CONFIG_NAND directly to include/configs/...
> instead this should come from board profiles defined in boards.cfg
> refer am335x_evm or description given in header of boards.cfg
> 

But TAM3517 is a SOM and it has always NAND. It is slightly different as
the am335x_evm. All boards using this SOM are then affected by this
problem, and fixing it in the SOM configuration file let us to make a
global fix for all boards, instead of adding CONFIG_NAND for each single
profile in boards.cfg.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-06-02  7:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 15:08 [U-Boot] [PATCH] tam3517: fix NAND detection Jeroen Hofstee
2014-06-02  6:16 ` Gupta, Pekon
2014-06-02  7:22   ` Stefano Babic [this message]
2014-06-02  7:30     ` Gupta, Pekon
2014-06-06 21:55 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538C2628.4090609@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.