From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] lpc_eth: Use resource_size instead of computation
Date: Mon, 02 Jun 2014 07:45:34 +0000 [thread overview]
Message-ID: <538C2B9E.8070409@bfs.de> (raw)
In-Reply-To: <1401290047-30005-3-git-send-email-benoit.taine@lip6.fr>
Am 02.06.2014 04:27, schrieb David Miller:
> From: Benoit Taine <benoit.taine@lip6.fr>
> Date: Wed, 28 May 2014 17:14:07 +0200
>
>> @@ -1419,8 +1419,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
>>
>> netdev_dbg(ndev, "IO address start :0x%08x\n",
>> res->start);
>> - netdev_dbg(ndev, "IO address size :%d\n",
>> - res->end - res->start + 1);
>> + netdev_dbg(ndev, "IO address size :%d\n", resource_size(res));
>> netdev_dbg(ndev, "IO address (mapped) :0x%p\n",
>> pldat->net_base);
>
> Please replace all of this with %pR as suggested by Joe, thanks.
Just for my curiosity: what does %pR mean ? (%p is ok, what is R ?)
re,
wh
next prev parent reply other threads:[~2014-06-02 7:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 15:14 [PATCH 0/2] Use resource_size instead of computation Benoit Taine
2014-05-28 15:14 ` Benoit Taine
2014-05-28 15:14 ` [PATCH 1/2] ALSA: au1x00: " Benoit Taine
2014-05-28 15:14 ` Benoit Taine
2014-05-28 15:51 ` Takashi Iwai
2014-05-28 15:51 ` Takashi Iwai
2014-05-28 15:14 ` [PATCH 2/2] lpc_eth: " Benoit Taine
2014-05-28 15:14 ` Benoit Taine
2014-05-28 16:16 ` Joe Perches
2014-05-28 16:16 ` Joe Perches
2014-06-02 2:27 ` David Miller
2014-06-02 2:27 ` David Miller
2014-06-02 11:24 ` [PATCH 2/2 v2] " Benoit Taine
2014-06-02 11:24 ` Benoit Taine
2014-06-02 11:34 ` [PATCH 2/2 v3] " Benoit Taine
2014-06-02 11:34 ` Benoit Taine
2014-06-02 17:58 ` David Miller
2014-06-02 17:58 ` David Miller
2014-06-03 10:32 ` [PATCH 2/2 v4] " Benoit Taine
2014-06-03 10:32 ` Benoit Taine
2014-06-03 10:45 ` [PATCH 2/2 v5] " Benoit Taine
2014-06-03 10:45 ` Benoit Taine
2014-06-03 23:09 ` David Miller
2014-06-03 23:09 ` David Miller
2014-06-02 7:45 ` walter harms [this message]
2014-06-02 11:28 ` [PATCH 2/2] " Benoit Taine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C2B9E.8070409@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.