From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 5/6] libxl: add libxl_vm_generation_id_set() Date: Mon, 2 Jun 2014 10:25:44 +0100 Message-ID: <538C4318.1040107@citrix.com> References: <1401211909-27771-1-git-send-email-david.vrabel@citrix.com> <1401211909-27771-6-git-send-email-david.vrabel@citrix.com> <1401289017.10916.16.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WrOV3-0001FB-5T for xen-devel@lists.xenproject.org; Mon, 02 Jun 2014 09:25:49 +0000 In-Reply-To: <1401289017.10916.16.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 28/05/14 15:56, Ian Campbell wrote: > On Tue, 2014-05-27 at 18:31 +0100, David Vrabel wrote: >> Add a function to allow a toolstack to set a domain's VM generation >> ID. >> >> Although the specification requires that a ACPI Notify event is raised >> if the generation ID is changed, in practice this appears not to be >> necessary if the generation ID is changed while the Windows VM is >> suspended. > > Do we (or did Microsoft) envisage scenarios where the ID might change > while the VM was not suspended? I think the specification has been written to allow for this. But when running on Xen I would not anticipate this being necessary. >> + /* >> + * Update the ID in guest memory (if available). > > Does "if available" here translate to "on restore"? (with on create > being handled by hvmloader, IOW this is the cooperation I was wondering > about on the docs patch) Yes. David