From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: Failed to set cache compression type Date: Mon, 02 Jun 2014 16:10:11 +0200 Message-ID: <538C85C3.5020808@metafoo.de> References: <538C840A.2000307@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-252.synserver.de (smtp-out-005.synserver.de [212.40.185.5]) by alsa0.perex.cz (Postfix) with ESMTP id 609D92652E7 for ; Mon, 2 Jun 2014 16:10:14 +0200 (CEST) In-Reply-To: <538C840A.2000307@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jarkko Nikula Cc: "alsa-devel@alsa-project.org" , Mark Brown , Fabio Estevam List-Id: alsa-devel@alsa-project.org On 06/02/2014 04:02 PM, Jarkko Nikula wrote: > On 06/02/2014 04:43 PM, Fabio Estevam wrote: >> Hi, >> >> I am booting linux-next 20140602 on a mx6qsabresd and I get the following >> probe >> error: >> >> wm8962 0-001a: customer id 0 revision D >> wm8962 0-001a: ASoC: Failed to set cache compression type: -22 >> imx-wm8962 sound: snd_soc_register_card failed (-22) >> imx-wm8962: probe of sound failed with error -22 >> >> What is the proper way to fix it? >> > I was looking at this too and it was introduced by the commit b59dce53ef61 > ("ASoC: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error."). I think snd_soc_cache_init() should return 0 rather than -EINVAL if reg_size is 0. > > If I understood commit 657254714ad2 ("ASoC: io: Remove support for ASoC > cache in conjunction with regmap") right should we remove remaining > soc-cache use? All codec drivers seems to include regmap.h although some of > them are still calling soc_cache_sync(). Yes, ASoC level support for caching is going to be removed, hopefully sooner than later. If a driver still uses soc_cache_sync() even though it has switched to regmap for IO that's a bug. - Lars