From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: remove check for generic timer support for arm64 Date: Mon, 02 Jun 2014 15:13:27 +0100 Message-ID: <538C8687.2060502@linaro.org> References: <1401698241-20722-1-git-send-email-vijay.kilari@gmail.com> <1401707388.11045.6.camel@kazak.uk.xensource.com> <538C5C64.3080805@linaro.org> <1401714226.19553.11.camel@kazak.uk.xensource.com> <538C7AC6.30900@linaro.org> <1401715834.21534.7.camel@kazak.uk.xensource.com> <538C7E97.30702@linaro.org> <1401717735.21534.24.camel@kazak.uk.xensource.com> <1401718288.21534.25.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401718288.21534.25.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Vijay Kilari Cc: Prasun Kapoor , Vijaya Kumar K , "xen-devel@lists.xen.org" , Stefano Stabellini , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 06/02/2014 03:11 PM, Ian Campbell wrote: > On Mon, 2014-06-02 at 19:38 +0530, Vijay Kilari wrote: >> On Mon, Jun 2, 2014 at 7:32 PM, Ian Campbell wrote: >>> On Mon, 2014-06-02 at 19:29 +0530, Vijay Kilari wrote: >>>> However generic timer is required for aarch64 mode. >>> >>> Do you have an ARM ARM reference for that? If true it would indeed >>> simplify things, but I was unable to find a statement along those >>> lines... >> >> Sorry, I too didn't not get any reference for this. >> But in arm64 where Aarch32 is optional, why should one rely on Aarch32 >> feature register >> if generic timer is anyway required for Aarch64 > > We shouldn't, the bug is that we are checking the AArch32 feature > register instead of the AArch64 one in this case (see the rest of this > thread). AArch64 doesn't have a similar feature bit in AA64PFR*. -- Julien Grall