From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTMq-0005UB-Sp for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:37:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrTMj-0000YW-N8 for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:37:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTMj-0000YO-Db for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:37:33 -0400 Message-ID: <538C8C29.8020408@redhat.com> Date: Mon, 02 Jun 2014 08:37:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ImVLl4fWrIV58WNTDit9mbQFNAFJIifQB" Subject: Re: [Qemu-devel] [PATCH v1 00/72] Extract qapi commons and block definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ImVLl4fWrIV58WNTDit9mbQFNAFJIifQB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/31/2014 05:50 AM, Beno=C3=AEt Canet wrote: > This hudge chainsawing series sit on top of my quorum maintenance serie= s. >=20 > It extract commons definition and block definition into separate files.= I'm not sure if you had to split it quite so fine (a series of three commits, one per file, might have been okay); but doing it one commit per function does make each individual patch easy to review. >=20 > -qapi/common.json contains some definition required by all qapi modules= > -qapi/block-core.json contains core qapi block definition usable withou= t the emulation > code. > -qapi/block.json is a superset of the previous usable with emulation >=20 > Transaction where left appart because they relies on internal snapshot = and hence > cannot be included in block-core.json for now. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ImVLl4fWrIV58WNTDit9mbQFNAFJIifQB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjIwpAAoJEKeha0olJ0NqXZsIAJ64Z1L+yRnlSmRvPOdbAt2c U3xXCZabPKOP0FMg0PghmO78pJs0e1e7Gv/g5pOglZIvPyosCz4FCiLP9RyJgmJu iEx4GcFeWLub2utaJY4vxUtgmKFfCCbYpZidFBcAeWJkY++HfL2ntdOyvZrZBD7q uhOqPFm2FXiTE90GbjN/k1FT6zdY9qlf6HUeDbKl3/DckKT6kV0IjinXZga7pFdj R9Yl/B3jZytJyskCnOm018M1Q4NPdbdafWeRKlYDNzBFXVFw5KyYHNrAMKmDs8iM BKGJVZ9Uw2D4jaXt7UNKNrHO1JgQnPgUq0g2uJZ6YlL9dzELh3pPlaBdrL4t0Fs= =2LeZ -----END PGP SIGNATURE----- --ImVLl4fWrIV58WNTDit9mbQFNAFJIifQB--