From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Jeff Cody <jcody@redhat.com>,
Benoit Canet <benoit@irqsave.net>,
stefanha@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 38/72] qapi: Extract block-stream definition into qapi/block-core.json
Date: Mon, 02 Jun 2014 09:04:37 -0600 [thread overview]
Message-ID: <538C9285.5010804@redhat.com> (raw)
In-Reply-To: <1401537111-10221-39-git-send-email-benoit.canet@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
On 05/31/2014 05:51 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
> qapi-schema.json | 38 --------------------------------------
> qapi/block-core.json | 38 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 38 insertions(+), 38 deletions(-)
21-38: Reviewed-by: Eric Blake <eblake@redhat.com>
I will point out that all this refactoring work will have conflicts with
other pending patches in the same area, such as Jeff's work on using
node-name in block-stream; but such conflicts should be obvious
resolutions (either series can go first, as long as the final result is
the improved command ending up in the new file). I don't know which
series going in first would be more of a conflict magnet to the other
series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-02 15:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:37 ` [Qemu-devel] [PATCH v1 00/72] Extract qapi commons and block definitions Eric Blake
[not found] ` <1401537111-10221-2-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:40 ` [Qemu-devel] [PATCH v1 01/72] qapi: Extract ErrorClass definition in qapi/common.json Eric Blake
[not found] ` <1401537111-10221-3-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:43 ` [Qemu-devel] [PATCH v1 02/72] qapi: Extract VersionInfo " Eric Blake
[not found] ` <1401537111-10221-6-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:45 ` [Qemu-devel] [PATCH v1 05/72] qapi: Extract query-commands definition into qapi/common.json Eric Blake
[not found] ` <1401537111-10221-7-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:47 ` [Qemu-devel] [PATCH v1 06/72] qapi: create two block related json modules Eric Blake
[not found] ` <1401537111-10221-9-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:48 ` [Qemu-devel] [PATCH v1 08/72] qapi: Extract ImageInfoSpecificQCow2 definition into qapi/block-core.json Eric Blake
[not found] ` <1401537111-10221-21-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:56 ` [Qemu-devel] [PATCH v1 20/72] qapi: Extract BlockStats " Eric Blake
[not found] ` <1401537111-10221-39-git-send-email-benoit.canet@irqsave.net>
2014-06-02 15:04 ` Eric Blake [this message]
[not found] ` <1401537111-10221-45-git-send-email-benoit.canet@irqsave.net>
2014-06-03 14:55 ` [Qemu-devel] [PATCH v1 44/72] qapi: Extract drive-mirror-replace " Eric Blake
2014-06-03 15:50 ` Benoît Canet
[not found] ` <1401537111-10221-73-git-send-email-benoit.canet@irqsave.net>
2014-06-03 15:01 ` [Qemu-devel] [PATCH v1 72/72] qapi: Extract nbd-server-stop definition into qapi/block.json Eric Blake
2014-06-04 14:34 ` [Qemu-devel] [PATCH v1 00/72] Extract qapi commons and block definitions Stefan Hajnoczi
2014-06-04 15:18 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C9285.5010804@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.