From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1WrU1R-00088v-Ju
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:19:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1WrU1J-0008FZ-6t
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:19:37 -0400
Received: from averel.grnet-hq.admin.grnet.gr ([195.251.29.3]:5140)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1WrU1I-0008FC-W5
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:19:29 -0400
Message-ID: <538C929B.6000304@grnet.gr>
Date: Mon, 02 Jun 2014 18:04:59 +0300
From: Chrysostomos Nanakos <cnanakos@grnet.gr>
MIME-Version: 1.0
References: <1401718539-11304-1-git-send-email-cnanakos@grnet.gr>
	<1401718539-11304-2-git-send-email-cnanakos@grnet.gr>
	<538C8A7D.1020402@redhat.com>
In-Reply-To: <538C8A7D.1020402@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: Support Archipelago as a
 QEMU block backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com

Hi,

On 06/02/2014 05:30 PM, Eric Blake wrote:
> On 06/02/2014 08:15 AM, Chrysostomos Nanakos wrote:
>> VM Image on Archipelago volume is specified like this:
>>
>> file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>]]
>> or
> I still think that there is no need to burden the code with this
> shorthand...

If everyone agrees I can totally remove that part.

>
>> file.driver=archipelago,file.volume=<volumename>[,file.mport=<mapperd_port>[,
>> file.vport=<vlmcd_port>]]
> ...when this version is easier to support.  Older protocols have file=
> abuse due to back-compat reasons, but new protocols should not start out
> with baggage.
>
>
>> ---
>>   MAINTAINERS         |    5 +
>>   block/Makefile.objs |    1 +
>>   block/archipelago.c | 1174 +++++++++++++++++++++++++++++++++++++++++++++++++++
> This is a lot to review at once - is there any reasonable way to break
> it into a series of smaller patches?

It will be really difficult to break it in smaller patches, and I 
believe it will more difficult for someone to review it.

>
> I still don't see anything added to the QMP blockdev-add command.
>

Totally forgot it, sorry for that. I will make the changes in v3, in a 
different patch!

Regards,
Chrysostomos.