Re: [PATCH v6 7/9] xl: enable getting and setting soft

[George Dunlap <george.dunlap@eu.citrix.com>]

On 05/28/2014 01:42 AM, Dario Faggioli wrote:
> Getting happens via `xl vcpu-list', which now looks like this:
>
>   # xl vcpu-list -s
>   Name       ID VCPU CPU State Time(s) Affinity (Hard / Soft)
>   Domain-0   0     0  11  -b-     5.4  8-15 / all
>   Domain-0   0     1  11  -b-     1.0  8-15 / all
>   Domain-0   0    14  13  -b-     1.4  8-15 / all
>   Domain-0   0    15   8  -b-     1.6  8-15 / all
>   vm-test    3     0   4  -b-     2.5  0-12 / 0-7
>   vm-test    3     1   0  -b-     3.2  0-12 / 0-7
>
> Setting happens by specifying two pCPU masks to the `xl vcpu-pin'
> command, the first one will be hard affinity, the second soft
> affinity. If only one mask is specified, it is only hard affinity
> that is affected. To change only soft affinity, '-' can be used
> as the hard affinity mask parameter, and it will be left alone.
>
> xl manual page is updated accordingly.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
> Changes from v5:
>   * change command line interface for 'vcpu-pin', as suggested during
>     review.
>
> Changes from v4:
>   * fix and rephrased the manual entry, as suggested during review;
>   * more refactoring to remove some leftover special casing, as
>     suggested during review.
>
> Changes from v3:
>   * fix typos in doc, rephrased the help message and changed
>     the title of the column for hard/soft affinity, as suggested
>     during review.
>
> Changes from v2:
>   * this patch folds what in v2 were patches 13 and 14;
>   * `xl vcpu-pin' always shows both had and soft affinity,
>     without the need of passing '-s'.
> ---
>   docs/man/xl.pod.1         |   32 ++++++++++++----
>   tools/libxl/xl_cmdimpl.c  |   90 +++++++++++++++++++++++++++++----------------
>   tools/libxl/xl_cmdtable.c |    2 +-
>   3 files changed, 84 insertions(+), 40 deletions(-)
>
> diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
> index 30bd4bf..f646bf6 100644
> --- a/docs/man/xl.pod.1
> +++ b/docs/man/xl.pod.1
> @@ -651,16 +651,32 @@ after B<vcpu-set>, go to B<SEE ALSO> section for information.
>   Lists VCPU information for a specific domain.  If no domain is
>   specified, VCPU information for all domains will be provided.
>   
> -=item B<vcpu-pin> I<domain-id> I<vcpu> I<cpus>
> +=item B<vcpu-pin> [I<OPTIONS>] I<domain-id> I<vcpu> I<cpus hard> I<cpus soft>

Are there actually any OPTIONS left now?

  -George