From: "Marcin Gibuła" <m.gibula@beyond.pl>
To: Paolo Bonzini <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] thread-pool: fix deadlock when callbacks depends on each other
Date: Mon, 02 Jun 2014 17:57:29 +0200 [thread overview]
Message-ID: <538C9EE9.70903@beyond.pl> (raw)
In-Reply-To: <538C990E.1080308@redhat.com>
>> I'll test it tomorrow. I assume you want to avoid calling
>> event_notifier_set() until function is reentered via aio_pool?
>
> Yes. But actually, I need to check if it's possible to fix
> bdrv_drain_all. If you're in coroutine context, you can defer the
> draining to a safe point using a bottom half. If you're not in
> coroutine context, perhaps bdrv_drain_all has to be made illegal. Which
> means a bunch of code auditing...
For what it's worth, your solution also works fine, I couldn't recreate
hang with it. Updated patch proposal posted earlier today.
--
mg
prev parent reply other threads:[~2014-06-02 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <538A1F71.4080203@beyond.pl>
2014-06-01 18:12 ` [Qemu-devel] [PATCH] thread-pool: fix deadlock when callbacks depends on each other Paolo Bonzini
2014-06-01 19:02 ` Marcin Gibuła
2014-06-02 15:32 ` Paolo Bonzini
2014-06-02 15:57 ` Marcin Gibuła [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C9EE9.70903@beyond.pl \
--to=m.gibula@beyond.pl \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.